check_plain('') returns </p> [#103079]

Since my provider upgraded to php 5.2 I notice that

_filter_autop('') -> returns </p> and not an empty string or <p></p>

Fixed it for now by putting this on top of _filter_autop

  if ($text === "") {  
    return $text;
  }

This was especially visible with the image module since all images have an empty body on my site...
it generated


<img src="someimageurl" alt="xxx" title="xxx"  class="image preview" width="413" height="550" /></p>

which is invalid html

Comment	File	Size	Author
#4	_filter_autop.patch	1.19 KB	yched

Comments

Comment #1

bwynants commented 14 December 2006 at 19:45

Installed PHP 5.2 on my computer

same issue...

empty string gets first replaced by 

<p>
</p>

then 
 
$chunk = preg_replace('!(</?'. $block .'[^>]*>)\s*</p>!', "$1", $chunk);

removes the first <p> and leaves the </p> in place

I'm not that familiar with reg exps so I leave this for the experts...

definetly not happening before 5.2

Comment #2

bwynants commented 23 January 2007 at 20:36

Version:

4.7.x-dev

» 5.0

same seems to happen on drupal 5

this is the cck output for an empty field.....

<div class="field-item"></p>
</div>

Comment #3

ChristopherFritz commented 22 April 2007 at 03:53

Version:

5.0

» 5.1

I just wanted to add, I had the same issue (while using Taxonomy context). The given solution [if ($text === "") { return $text; } ] works like a charm (thanks!)

This is a real problem for those using XHTML (application/xhtml+xml), and it appears to be an easy solution.

$Id: filter.module,v 1.160 2007/01/12 07:27:21 unconed Exp $

Comment #4

yched commented 31 May 2007 at 10:02

Version:	5.1	» 6.x-dev
Status:	Active	» Needs review

Status	File	Size
new	_filter_autop.patch	1.19 KB

This should be a better fix - there is a mistake in one of the regexps in _filter_autop
Moving to Drupal 6, since this should be fixed here first, then backported.

The patch is for D6, but should apply to D5 (with an offset).