Pacth: Removed Drupal.settings.hide_submit.image and include patch #1030622 [#1030638]

This patch includes patch Patch: Added using Drupal.behaviors instead of $(document).ready() and JS code optimization. and also removed code that creates JS-variable Drupal.settings.hide_submit.image and uses at client side.

Comment	File	Size	Author
#3	hide_submit_6.x-1.10_JS_optimization_#1030638.patch	6.29 KB	VladSavitsky
#4	hide_submit_6.x-1.10_JS_optimization_1030638.patch	6.29 KB	VladSavitsky
#1	hide_submit_6.x-1.10_JS_optimization_#1030638.patch	6.29 KB	VladSavitsky

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #2

Optalgin CreditAttribution: Optalgin commented 18 January 2011 at 12:44

Can't see attachment, link is broken.
please post again (don't use # in filename)
Thanks

Comment #3

VladSavitsky CreditAttribution: VladSavitsky commented 18 January 2011 at 19:38

File	Size
hide_submit_6.x-1.10_JS_optimization_#1030638.patch	6.29 KB

Yes. Link is broken.
Here is the same patch attached to this comment.
Update: this one broken too.

File	Size
hide_submit_6.x-1.10_JS_optimization_1030638.patch	6.29 KB

Comment #5

Optalgin CreditAttribution: Optalgin commented 18 January 2011 at 22:56

Hi,
Can you please explain why you think image should be removed from settings?

The reason I put it there is to allow preload the image

    if (settings.image) {
       jQuery("<img>").attr("src",settings.image);
    }

Comment #6

VladSavitsky CreditAttribution: VladSavitsky commented 20 January 2011 at 01:08

I have tested and throbber image was shown after appling this patch but seems that browser get it from cache.
(I thought that this image is in CSS).
So this is wrong to just remove this line.
And adding CSS-file for just one background image is silly.
Ok. I'll fix this patch.