I'm working on #781246: Write Git-specific packaging plugin for d.o but due to problems with how git-dev.d.o is currently configured and confusion about how everything's really going to live on the filesystem, I can't actually write that patch in a way that's going to work when we launch. For now, it's just going to have to assume it's running on a single host that both has the Drupal root for the site and has a copy of /var/git that works. We should fix this before launch so that it checks out via http:// or git:// and uses stable URLs that aren't going to change.

Comments

eliza411’s picture

Assigned: Unassigned » sdboyer

sdboyer, not sure how you're grouping the file system issues, but would you update this when that issue gets opened?

dww’s picture

Seems like this is blocked on #1038404: Determine an approach to managing git repositories on disk for now. Perhaps others.

sdboyer’s picture

Not blocked on that, actually. For now the scripts are perfectly fine relying on the local filesystem path contained in $repo->root. We won't need to revisit for several months after launch, at least. Untagging accordingly.

drumm’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Assigned: sdboyer » drumm
Issue summary: View changes
Status: Postponed » Active
Parent issue: » #2304983: 'wget' used by packager has trouble downloading certain files from GitHub (like TinyMCE)
drumm’s picture

Damien Tournoud’s picture

@drumm: if you want to still use git archive, the easiest path is probably to:

  • Update the code to use git archive --remote=<URL> ..., where <URL> is a simple Git-protocol URL (ie. one with git://);
  • Update the configuration of the git-daemon on util so that it allows the upload-archive service.

There are two alternative paths, but I don't think they are desirable:

  • Clone the whole repository (in --shallow) and export the archive from there;
  • Move the repositories to NFS and access them directly from jenkins1
drumm’s picture

I think I may go with a variation on

Clone the whole repository (in --shallow) and export the archive from there;

There are some more Git operations that happen for branch packaging in computeRebuildVersion(). My testing shows that works with a --depth 0 clone.

(I'm also not eager to change the Git daemon config.)

drumm’s picture

Actually, --depth 1 is what I would want for a shallow clone, and it doesn't help computeRebuildVersion(). That code looks like it needs a full clone locally, or at least the history back to the most recent tag on the branch. We will need to do a full clone anyway.

  • drumm committed 27684a1 on 7.x-3.x
    #1028950 Cleanup to use pre-filled variable names.
    
  • drumm committed 56b9965 on 7.x-3.x
    #1028950 Fix packaging scripts to checkout from sane/stable Git URLs...
drumm’s picture

Status: Active » Fixed
Issue tags: +needs drupal.org deployment
drumm’s picture

Issue tags: -needs drupal.org deployment

Now deployed.

  • drumm committed 8602fb7 on 7.x-3.x
    #1028950 Clean up the clone because drush_delete_tmp_dir() is slow, and...

  • drumm committed df1bfe0 on 7.x-3.x
    #1028950 rm -rf is faster.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.