logo_upload in form_set_error instead of favicon_upload in system.admin.inc [#1025286]

Comment	File	Size	Author
#8	D7-favicon-error-1025286-8.patch	492 bytes	Tor Arne Thune
#5	favicon-error-1025286-5.patch	512 bytes	devin carlson
#4	1025286_without_patch.jpg	33 KB	opi
#4	1025286_with_patch.jpg	34.13 KB	opi
#2	favicon-error-1025286-2.patch	492 bytes	Tor Arne Thune
	favicon_error.patch	829 bytes	swentel

Comment #1

chx commented 13 January 2011 at 10:35

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

Log in or register to post comments

Comment #2

Tor Arne Thune commented 20 June 2011 at 19:10

Version:	7.x-dev	» 8.x-dev
Issue tags:		+Quick fix, +Needs backport to D7

Status	File	Size
new	favicon-error-1025286-2.patch	492 bytes

Still a valid issue in Drupal 7.2. Re-rolled the patch against branch 8.x.

Log in or register to post comments

Comment #3

Tor Arne Thune commented 20 June 2011 at 19:10

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #4

opi

French

commented 11 January 2012 at 10:53

Status	File	Size
new	1025286_with_patch.jpg	34.13 KB
new	1025286_without_patch.jpg	33 KB

The patch in #2 works fine for me, see attached screenshots

Log in or register to post comments

Comment #5

devin carlson commented 13 January 2012 at 06:13

Status	File	Size
new	favicon-error-1025286-5.patch	512 bytes

Another +1 to the patch in #2. It works (see the screenshots in #4), but it requires a re-roll as it was created before D8 moved everything to /core.

The attached patch is a simple re-roll.
I'll mark this issue as RTBC assuming the patch passes tests.

Log in or register to post comments

Comment #6

devin carlson commented 13 January 2012 at 12:44

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

Comment #7

catch

he/him

English

commented 19 January 2012 at 17:44

Version:	8.x-dev	» 7.x-dev
Status:	Reviewed & tested by the community	» Patch (to be ported)
Issue tags:	-Needs tests

This makes sense. It's a sufficiently minor bug (and on only visual) that I don't think we need an automated test for it. So I've gone ahead and committed/pushed to 8.x.

Marking for backport.