masquerade_user_update doesn't check whether $edit['masquerade_users'] is set, data loss occurs

Could you provide detailed steps to reproce this notice?

Using 'drush version 4.2' I have no this message

# drush pmi masquerade
 Project          :  masquerade
 Type             :  module
 Title            :  Masquerade
 Description      :  This module allows permitted users to masquerade as other users.
 Version:
 Package          :  Other
 Core             :  7.x
 Status           :  not installed
 Path             :  sites/drupal7/modules/masquerade
 Schema version   :  no schema installed
 Files            :  masquerade.install, masquerade.module
 Requires         :  none

# drush en masquerade
The following extensions will be enabled: masquerade
Do you really want to continue? (y/n): y
masquerade was enabled successfully.                                                                           [ok]

# drush pmi masquerade
 Project          :  masquerade
 Type             :  module
 Title            :  Masquerade
 Description      :  This module allows permitted users to masquerade as other users.
 Version:
 Package          :  Other
 Core             :  7.x
 Status           :  enabled
 Path             :  sites/drupal7/modules/masquerade
 Schema version   :  7000
 Files            :  masquerade.install, masquerade.module
 Requires         :  none

I have this issue too:

Notice: Undefined index: masquerade_users in masquerade_user_update() (line 443 of D:\inetpub\wwwroot\IDNCore\sites\all\modules\masquerade\masquerade.module).

I can reproduce it when logged in as user 1 (not masquerading), and either subscribing to an Organic Group or leaving an Organic Group.

This happens whenever something does a programmatic user_save with limited scope.

masquerade is blindly assuming that $edit['masquerade_users'] exists, which isn't the case if something is calling user_save() directly with a partial $edit array that just contains the pieces that it's changing.

Drupal 7 code is supposed to be E_ALL compliant, which includes E_NOTICE notices about undefined variables.

Both isset() and empty() can be used to check possibly undefined variables without generating a notice. A good fix is to wrap the code in if (isset($edit['masquerade_users'])) { ... }. Additionally, I would argue that the if ($category == 'account') { check is unnecessary.

See http://drupal.org/node/34341 for more information.

This also causes loss of whatever names were in the field.

isset() is TRUE for '', so it doesn't affect the ability to clear out the field.

Patch attached.

Thanx, commited http://drupalcode.org/project/masquerade.git/commit/a11dd23
Also backported to 6.x-1.x http://drupalcode.org/project/masquerade.git/commit/40cdab2

I am also getting this Error upon new account creation.

I am also getting this Error upon new account creation.

Notice: Undefined index: masquerade_users in masquerade_user_update() (line 443 of /home8/kpcprodu/public_html/americanwrc/sites/all/modules/masquerade/masquerade.module).
Notice: Undefined index: masquerade_users in masquerade_user_update() (line 443 of /home8/kpcprodu/public_html/americanwrc/sites/all/modules/masquerade/masquerade.module).

How do I fix this? I might need step by step instructions, I have never installed an module patch before...

Or should I just wait for the next Masquerade module update to come out and hope it fixes the bug...

I also get this same error after enabling organic groups and creating a group node...

This already fixed RC-4 is waiting for
#1258376: Incompatible SQL statement for SQL Server
#1116034: The masquerade block is displayed regardless of permission