Hey,

Found a little bug in the javascript file: privatemsg-list.js

The current code is as follows:

$('#privatemsg-list #edit-operation').change(function () {
  $('#edit-submit').click();
});

The "#edit-submit" id is not reliable because other forms on the page may cause it to be incremented ("edit-submit-2", etc.)

I have attached a patch that fixes this by making the following change:

$('#privatemsg-list #edit-operation').change(function () {
  $('div.privatemsg-op-button input.form-submit').click();
});

Cheers!

CommentFileSizeAuthor
fix-privatemsg-list-js.patch556 byteste-brian

Comments

berdir’s picture

Status: Needs review » Fixed

Thanks, nice catch.

Commited to 6.x-2.x and 6.x-1.x.

te-brian’s picture

BTW, not to spam but I've been very impressed with the module so far. Most things actually work as advertised :)

We'll be doing some custom integration work and I'll see what can be contributed back as a standalone sub-module.

berdir’s picture

Thanks ;)

Feel free to contact me directly (using the contact form) to discuss your plans :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.