Attribute for embedded images not in output [#1018606]

Comment	File	Size	Author
#6	honor-class-override-1018606-6.patch	1.16 KB	aaron
#3	styles-1018606.patch	1.13 KB	Jackinloadup

Comment #1

aaron CreditAttribution: aaron commented 11 January 2011 at 20:38

Project:	D7 Media	» Styles
Version:	7.x-1.x-dev	» 7.x-2.x-dev

moving to proper queue.

Log in or register to post comments

Comment #2

Jackinloadup CreditAttribution: Jackinloadup commented 25 January 2011 at 00:14

i have run into this issue as well. My biggest issue is it dropping style. Might take a look into it if i can get a change. Any one know anything about the source of the problem? any leads?

Log in or register to post comments

Comment #3

Jackinloadup CreditAttribution: Jackinloadup commented 26 January 2011 at 23:22

File	Size
styles-1018606.patch	1.13 KB

Ok so i had found a fix for 7.x-2.0-alpha4 but things seems to have changed pretty dramatically in the areas I was dealing with between alpha4->5.

the information about the the wysiwyg style and class settings are in the override array which shows up in the $variables array for the theme functions. Namely theme_file_styles_image.

I was able to get a working patch but it seems kinda janky. Please review!!!!!!!!

Things I noticed
styles/contrib/file_styles/file_styles.theme.inc
seems to be replaced with
styles/contrib/file_styles/includes/themes/file_styles.theme.inc

yet styles/contrib/file_styles/file_styles.theme.inc still exists.

Log in or register to post comments

Comment #4

tsvenson CreditAttribution: tsvenson commented 17 February 2011 at 02:49

Status:

Active

» Needs work

Seems to partially fix the problem. The classes are now there, but I also get these errors:

# Notice: Undefined property: stdClass::$override in theme_file_styles_image() (line 15 of [path]\sites\all\modules\styles\contrib\file_styles\includes\themes\file_styles.theme.inc).
# Notice: Undefined property: stdClass::$override in theme_file_styles_image() (line 16 of [path]\sites\all\modules\styles\contrib\file_styles\includes\themes\file_styles.theme.inc).

At first view of the page I get them once, then they seems to be cached somehow and are shoring up twice.

This is with latest dev releases of Media/Styles.

Log in or register to post comments

Comment #5

mrfree CreditAttribution: mrfree commented 22 February 2011 at 11:00

Nothing changes in file_style between alpha5 and dev (Last updated: January 19, 2011 - 01:39)

--- styles-alpha5/contrib/file_styles//file_styles.info	2011-02-22 10:31:37.164246164 +0100
+++ styles-dev/contrib/file_styles//file_styles.info	2011-01-19 01:39:50.000000000 +0100
@@ -11,8 +11,8 @@
 dependencies[] = image
 
 ; Information added by drupal.org packaging script on January 1, 1970 - 00:00
-version = "7.x-2.0-alpha5"
+version = "7.x-2.x-dev"
 core = "7.x"
 project = "styles"
-datestamp = "1295391391"
+datestamp = "1295397590"

Log in or register to post comments

Comment #6

aaron CreditAttribution: aaron commented 10 March 2011 at 04:24

Status:

Needs work

» Needs review

File	Size
honor-class-override-1018606-6.patch	1.16 KB

here, try this patch. don't have time to test right now. thanks!

Log in or register to post comments

Comment #7

tsvenson CreditAttribution: tsvenson commented 10 March 2011 at 04:47

Will give it a spin tomorrow. So you got the code spint at DrupalCon going then? :)

Log in or register to post comments

Comment #8

aaron CreditAttribution: aaron commented 10 March 2011 at 14:01

yes, there was some awesome work accomplished -- some patches towards views integration, moving media entities to file entities and more!

Log in or register to post comments

Comment #9

tsvenson CreditAttribution: tsvenson commented 10 March 2011 at 15:30

Status:

Needs review

» Reviewed & tested by the community

Oki, Aaron. As promised I have now tested your patch and it does the trick. Classes are now again available in the output code. Great work.

This is tested with today's Styles dev release. The commit burst for the Media module has not yet propagated to the dev tarball so it's not tested with that. Doubt it should affect this though.