Taxonomy Manager broken - incompatibility with Tao based themes (like Rubik)

the taxonomy manager relies on some ids in fieldsets.
the tao theme overrides the fieldset theme function, but the #id attribute gets lost. adding of element_set_attributes($element, array('id')); to the function tao_preprocess_fieldset (as it is done in the original theme_fieldset) solves the problem.

in my opinion, this fix should be added to the Tao theme

agree

Bravo.

For Rubik and subthemes the best option for those who do not want to touch Tao is to copy the entire tao_preprocess_fieldset(&$vars) function over to Rubik template.php, replacing the one there, applying this fix and making sure to rename it accordingly: rubik_preprocess_fieldset(&$vars).

Tested it, works like butter.

Hello kannary,
I've tested your solution but it dosen't work for me. this is my code for \themes\rubik\template.php
It's not very important because it's work with the seven theme...
Bye.

/**
 *OLD Preprocessor for theme('fieldset').
 
function rubik_preprocess_fieldset(&$vars) {
  if (!empty($vars['element']['#collapsible'])) {
    $vars['title'] = "<span class='icon'></span>" . $vars['title'];
  }
}*/
/**
 *NEW  Implementation of preprocess_fieldset().
 */
function rubik_preprocess_fieldset(&$vars) {
  $element = $vars['element'];
  $vars['attributes'] = $element['#attributes'];
  $vars['attributes']['class'][] = 'fieldset';
  if (!empty($element['#title'])) {
    $vars['attributes']['class'][] = 'titled';
  }

  $description = !empty($element['#description']) ? "<div class='description'>{$element['#description']}</div>" : '';
  $children = !empty($element['#children']) ? $element['#children'] : '';
  $value = !empty($element['#value']) ? $element['#value'] : '';
  $vars['content'] = $description . $children . $value;
  $vars['title'] = !empty($element['#title']) ? $element['#title'] : '';
  $vars['hook'] = 'fieldset';
}

Attached is a patch for rubik's preprocess function to preserve the ID attribute. Apply to template.php.

This fix was included in #1105086: Add element id to fieldsets

Setting this to active again, because for

Tao 7.x-3.0-beta4
Rubik 7.x-4.0-beta8
Taxonomy Manager 7.x-1.0-rc1
Drupal 7.19

the issue still shows up.

For Taxonomy Manager, the issue has been filed as #874488: Clicking Add button does nothing - incompatibility with Devel module and Tao based themes (like Rubik).
There in #30, a change to tao's template php is suggested, which seems to fix the issue.

Please, kindly review the fix and consider adding it to tao.

Adding a patch for latest dev

Attached is the same patch in #12 without the whitespace issues.

Can confirm this resolves the bug.

Also worth reading is #874488: Clicking Add button does nothing - incompatibility with Devel module and Tao based themes (like Rubik)

re-titling for better searchability

Committed: 2eef901

Thanks!