This is an implementation issue for #984734: Meta: Visually distinguish sandbox projects from regular projects when viewing them
On the user-specific project view add:
a) An exposed filter to limit the list to "sandbox" projects, which will be toggled to On by a link in the title of the user's Project page.
b) A "sandbox" column to the table which indicates if it's a sandbox project or not.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | tggm_sandboxandfull.png | 46.26 KB | eliza411 |
| #9 | 1012186-9.your-projects-separate-table-for-sandboxes.patch | 4.81 KB | dww |
| #9 | 1012186-9.full-only.png | 31.54 KB | dww |
| #9 | 1012186-9.sandbox-only.png | 30.72 KB | dww |
| #9 | 1012186-9.both_.png | 53.21 KB | dww |
Comments
Comment #1
dwwNote that the table in question isn't a view, but is hard-coded in project_issue_my_projects_table().
Comment #2
eliza411 commentedLooking for someone to do this ...
Comment #3
dwwIf all else fails, I can probably get to it over the weekend once packaging is done...
Comment #4
eliza411 commentedThis seems seems necessary no matter what, but the way the UI works should probably compliment implementation of #991486: Add a setting to hide sandbox projects from global issue queues
Adding a cross-reference, too, because this might also be affected by the overall strategy #1031578: [Meta] Reflect a consistent strategy for sandbox visibility
Comment #5
dwwI'll work on this today during my break in class. I'll probably be offline. So, just wanted to assign to myself so no one else duplicates the effort. I'll hopefully post a patch late tonight when I'm back online.
Cheers,
-Derek
Comment #6
dwwHere's an initial patch. Still not done, since I really need to talk to someone about the UI for all this. There's currently no exposed filters on the top table at all, only the bottom table (the issues for the given projects). So, I'm not sure where/how to add the exposed filter. The attached patch at least modifies the query based on $_GET['sandbox'], so we could link directly if we wanted, but there's no way to toggle this via the UI itself.
Also, I'm not thrilled with adding a whole new column for the sandbox bit. I'd rather prepend "Sandbox: " to the project titles, maybe with a warning icon. Here's what it looks like in Garland given the current patch:
Comment #7
Bojhan commentedI think we need to separate "Official projects" from "Sandbox projects", this to make the conceptual separation between the two even more clear. This would mean two tables, one for official projects and one for sandboxes.
Project by a
Table of official projects
Sandbox's by a
Table of Sandboxes.
Comment #8
dwwRight. Bojhan and I had a good IRC UI chat here. The "filter" as such won't exist. But, we'll have a href anchor on the 2nd table so you can link to http://drupal.org/project/user/dww#sandbox or something if you want to jump to the 2nd table from somewhere else. The existing patch is basically useless at this point, so back to active for a whole new approach. ;) I'll work on it later today or this evening. Gotta run for a class right now.
Comment #9
dwwYay, much better.
Comment #10
dwwThe only minor problem here is that drupalorg_crosssite is doing whacky things with the page title and navigation on this page when it's a subtab on your dashboard/profile. See the difference between
http://drupal.org/project/user
and
http://drupal.org/project/user/[your-username]
For example, http://drupal.org/project/user/dww
So, that's going to slightly complicate things in the case where a user is viewing their own page and all they have are sandboxes. There's not going to be anything indicating they're just sandboxes. But, it's only for the user themselves. If someone else is viewing their page, it's going to need the final argument, and then things should work fine. I don't know if we care, but I wanted to raise it for consideration...
Also, tagging for a UX review, although presumably Bojhan will see this since he's already subscribed...
Comment #11
dwwp.s. One thing we could do is use a "Sandbox project" as the column header for the first column in the table for sandboxes. That way, even in the case in #10, we still have a slight hint we're looking at sandboxes.
Comment #12
eliza411 commentedI can see the value in adding the Sandbox Project as a column header. I wouldn't even mind the redundancy of a header that said Type and either Project or Sandbox as a value, especially if there will really be cck-style different types of project in the future.
+1 to what I see in the screen shots, especially with the addition of a column.
Comment #13
dwwI don't want to add a whole new column if we don't have to. This table is already a bit cluttered and very full, and we've got a fixed # of pixels to work with. Plus, it's redundant to have the same value in every row in the column for each table. But, I could at least change the column header on the sandbox table as I mentioned.
Comment #14
Bojhan commentedDww's screenshot looks good.
Comment #15
dwwGreat, hearing no further objections, I committed to project_issue HEAD. This will be live on git-dev on the next rebuild.
Comment #16
eliza411 commenteduser411, a 'Git user' has a single sandbox.
http://git-dev.drupal.org/project/user/user411 produces "This user has no projects."
http://git-dev.drupal.org/project/user shows the table in question without a Sandbox header.
After I promote the sandbox to a full project, content is listed on the project page. (This seems inconsistent with #1031578: [Meta] Reflect a consistent strategy for sandbox visibility)
Either way, though, I'm not seeing the new header and separate tables.
Comment #17
dwwSomething tells me project_issue hasn't been upgraded and deployed on git-dev.
http://drupal.org/cvs?commit=486278
And lo. The copy of project_issue.module on git-dev is:
Not sure why this isn't getting merged and deployed. I thought sdboyer had a script that does that automatically...