"smtp_from" and "site_email" should be being loaded as default FROM values, but they aren't, due to a wrong "if" condition. Patch attached.

CommentFileSizeAuthor
#1 smtp_module_1012062.patch981 bytesjosesanmartin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josesanmartin’s picture

FileSize
981 bytes

Patch attached & commited at 6 branch.

josesanmartin’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev

Must do the same in 7 branch.

yettyn’s picture

Assigned: josesanmartin » yettyn
Status: Active » Needs work

Didn't see this until now as I've been away, and I will leave again tomorrow to be hospitalized for 5 days. Nothing serious, but I have an annoying and sometimes laud tinnitus on the left ear, so when visiting the hospital today for some examination I was surprised, no shocked, to hear the doctor say he wanted to keep me there for 5 days doing some treatment by infusion and further examination!

He didn't want to listen to my self diagnose that 5 days away from the computer will probably kill me but while I cannot take it with me in at least he was nice to give me a day to put my stuff in order to check in tomorrow morning instead. Well if he manage to switch of that megaphone I'm all for it!

So I will at least try to get a patch up, in case I don't manage to commit it being a bit unsure about the status of my CVS installation.

yettyn’s picture

Status: Needs work » Fixed

Ok commit done, jumped the review step as this was crystal clear and 6.x already been committed without it as well. See you in 5-6-7 or so...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.