hello,

I tried to configure an action (following the documentation) but after creating the action without problem, there is nothing on the trigger section, so I can't set up anything. I missed something ?

disable/enable triggers module doesn't help. Should I go to the dev version ?

Comments

apprayo’s picture

Same here. Subscribing.

apprayo’s picture

I tested it on 2.2-dev, but still no trigger related to ad-clicking.

mich5’s picture

Hi,

thanks for trying the dev version, I didn't, and it's not resolving the trigger 'problem' at least for us.

aitala’s picture

I'm having the same problem... however, it does appear that ad expiration email(s) are being sent.

Eric

mich5’s picture

When I tried to access directly the ad_actions tab (ad_actions_hook_info() gave me the tab name)
with this url: example.com/admin/build/trigger/ad_actions
I 've a "strange" Access denied ! I 'm logged as user 1 ...
With new role and {module ad_actions >>> administer ad triggers} set to true, same story.
In fact Access rights don't seem to behave correctly for me. I don't know what to do now.

foxtrotcharlie’s picture

I solved this in ad_actions.module by removing the ad_actions_menu_alter function declaration and adding the following to function ad_actions_hook_info:

'access arguments' => array('administer ad triggers'), so that it looks like:

/**
 * Implementation of hook_hook_info().
 * Define all available ad triggers.
 */
function ad_actions_hook_info() {
  return array(
    'ad_actions' => array(
      'ad_actions' => array(
        'click' => array(
          'runs when' => t('An advertisement has been clicked.'),
        ),
        'approved' => array(
          'runs when' => t('An advertisement has been approved.'),
        ),
        'pending' => array(
          'runs when' => t('An advertisement has been marked as pending.'),
        ),
        'offline' => array(
          'runs when' => t('An advertisement has been marked as offline.'),
        ),
        'denied' => array(
          'runs when' => t('An advertisement has been denied.'),
        ),
        'active' => array(
          'runs when' => t('An advertisement has been activated.'),
        ),
        'expired' => array(
          'runs when' => t('An advertisement has expired.'),
        ),
        'created' => array(
          'runs when' => t('An advertisement has been created.'),
        ),
        'update' => array(
          'runs when' => t('An advertisement has been updated.'),
        ),
        'delete' => array(
          'runs when' => t('An advertisement has been deleted.'),
        ),
        'autoactivated' => array(
          'runs when' => t('Scheduled activation.'),
        ),
        'autoexpired' => array(
          'runs when' => t('Scheduled expiration.'),
        ),
      ),
      'access arguments' => array('administer ad triggers'),      
    ),
  );
}

Rebuild your menus, and you should now see the "Ad actions" tab on the admin/build/trigger page.

I'll create a patch and will post it shortly.

foxtrotcharlie’s picture

Category: support » bug
Status: Active » Needs review
StatusFileSize
new932 bytes

The Ad actions trigger tab was not showing up as a tab on the trigger page. This patch moves the user access check from the hook_menu_alter function to the hook_hook_info function. I'm not sure why the original method didn't work.

After patching, you should see a tab titled "Ad actions" at the top of the admin/build/trigger page. This patch is for version 6.x-2.2 of the ad_actions module.

mich5’s picture

thanks foxtrotcharlie !

I applied the patch and yes, ad_actions tab is there in the trigger section.
I need to test notifications now.

thanks again.
Michel

lrwebks’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)

Drupal 6 is EOL and no longer supported. Closing this as outdated for that reason. Thanks for your contribution!