Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Thanks for this useful module, we've been using it for some time now.
With the 6.x-1.6 version the buttons no longer display text with & instead display & which the patch in #5 fixes but it has not been committed.
With the 7.x-1.0-beta1 version, the field "Text to use for Save & Edit button" does not support & character instead display &
Meanwhile the field "Text to use for default Save button" works fine.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | save_edit-handle-special-characters-1002152-13.patch | 1.1 KB | izmeez |
| #5 | save_edit-1002152-5.patch | 2.04 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettIt was caused by the changes made here: http://drupal.org/cvs?commit=462646. The defaults were changed from "Save & Edit" to "Save and Edit", but that wouldn't current installations.
check_plain()is intended for user submitted values, not admin defined variables. It converts plain text to HTML, but can't be used on #value, which doesn't expect HTML.This should be rolled back.
Comment #2
tim.plunkettBump.
Comment #3
mattwmc CreditAttribution: mattwmc commentedI have the same problem.
Thanks.
*edited - just went into the admin settings and changed the '&' to 'and'
No big deal for me.
Comment #4
kahunacohen CreditAttribution: kahunacohen commentedI would be willing to jump in and fix this, but I've never contributed before. Is anyone else working on this?
Comment #5
tim.plunkettMy reference to CVS in comment #1 now is unclear, here is the proper fix.
Comment #6
izmeez CreditAttribution: izmeez commentedtim, thanks for the patch in #5. I had to apply it manually to 6.x-1.6 and it seems to work to fix the problem. I have created a new patch that is attached.
Comment #7
tim.plunkettGit now uses patches with prefixes, so to apply it would be
patch -p1 < PATCHNAME.patch.See the git instructions tab for each project on how to roll patches, that way it works with
git amand contains patch author info.Comment #8
izmeez CreditAttribution: izmeez commentedTim, Thanks for the reminder. I'll have to test that.
Comment #9
izmeez CreditAttribution: izmeez commentedTim, Yes you are absolutely correct the patch in #5 applies without any problem and works. The patch in #6 is old style and not needed. Thanks.
Izzy
Comment #10
izmeez CreditAttribution: izmeez commented+bump The patch in #5 works and restores the behavior of the module handling special characters as it did prior to 6.x-1.6 so might it be committed? Thanks.
Comment #11
izmeez CreditAttribution: izmeez commentedUpdating the issue to reflect problem on 7.x branch.
The field "Text to use for Save & Edit button" does not support
&character, while the field "Text to use for default Save button" works fine.Comment #12
izmeez CreditAttribution: izmeez commentedTrying to hide patch file in comment #6. It is not needed.
It is hidden in issue summary but still appears in comment #6.
Comment #13
izmeez CreditAttribution: izmeez commentedHere is a simple patch for 7.x-1.x based on comment #5.
Comment #14
NitinSP CreditAttribution: NitinSP at Cognizant Technology Solutions commentedComment #15
NitinSP CreditAttribution: NitinSP at Cognizant Technology Solutions commented@izmeez #13 patch is working fine for me. Thanks for providing patch, Nice Work..
Comment #17
NitinSP CreditAttribution: NitinSP at Cognizant Technology Solutions commented