in viewreference field settings, with "Views that can be referenced" having some checked (using number of values = 1), on the select options in the node edit form, since upgrading from 6.x-2.24 to 6.x-3.0 it now shows all views, where it used to correctly show only options that are checked.

I've resaved the content type, view + node. I have 4 different examples of using viewreference and this is broken on all of them.

Comments

echoz’s picture

echoz commented

This might be a clue, as this also seems amiss - in the dropdown, even though my view displays have titles, after my title it adds [viewname:viewdisplay_n]
Looking at - function viewreference_get_display_title - it doesn't look like it should do that ("This views display has a nice title, let's use that").

danielb’s picture

danielb commented

It appends that [viewname:viewdisplay_n] to all the views in case some have the same title.

I'll look into this in a bit.

danielb’s picture

danielb commented
Status: Active » Fixed

Sorry about that mate, it's fixed and a new release is coming.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

brian_c’s picture

brian_c commented
Version: 6.x-3.0 » 6.x-3.3
Status: Closed (fixed) » Active

We are seeing this same problem with the new 6-3.3 version.

We had recently upgraded to 6-3.2, and ran into #1031198: After Upgrading from 6.24 to 6.32; all the "Views that can be referenced" options were gone (ie, unselected) from the field definition, and all the select fields on node edit pages were empty (no values).

We then upgraded to 6-3.3. Now all the select fields on node edit pages are showing ALL views (which is certainly better than showing nothing!), but are not respecting the "Views that can be referenced" options from the field definition; it just shows everything.

danielb’s picture

danielb commented
Status: Active » Fixed

Alright I've hunted the bug down that was causing that.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

johnv’s picture

johnv
Primary language Dutch
commented
Version: 6.x-3.3 » 7.x-3.0-rc1
Status: Closed (fixed) » Patch (to be ported)

I have the same issue with the 7.x version. Can you apply the correction to the D7-branch, too? Thanks.

Shadlington’s picture

Shadlington commented

Subscribing

danielb’s picture

danielb commented
Status: Patch (to be ported) » Fixed

I've ported over the filter changes from D6->D7 now. Let me know if you have any more issues with this.

johnv’s picture

johnv
Primary language Dutch
commented
Version: 7.x-3.0-rc1 » 7.x-3.x-dev
Status: Fixed » Patch (to be ported)

I tested with today's D7 version, but the issue is not fixed. Will it reduce the list of Views in the NodeEdit-DefaultValues field, too?

danielb’s picture

danielb commented
Version: 7.x-3.x-dev » 7.x-3.0

Yes it reduces the list of views in the default values bit as well.
Works for me.... using 7.x-3.0, try that one

johnv’s picture

johnv
Primary language Dutch
commented
Status: Patch (to be ported) » Fixed

It's OK now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.