Port to Drupal 7 Needed
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 993594-15.patch | 6.77 KB | thill_ |
| #14 | 993594-14.patch | 3.76 KB | thill_ |
| #8 | 993594-8.patch | 5.71 KB | thill_ |
| #7 | feeds_youtube.diff | 5.23 KB | mikejoconnor |
| #4 | drupal7.patch | 4.03 KB | BlakeLucchesi |
Port to Drupal 7 Needed
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 993594-15.patch | 6.77 KB | thill_ |
| #14 | 993594-14.patch | 3.76 KB | thill_ |
| #8 | 993594-8.patch | 5.71 KB | thill_ |
| #7 | feeds_youtube.diff | 5.23 KB | mikejoconnor |
| #4 | drupal7.patch | 4.03 KB | BlakeLucchesi |
Comments
Comment #1
thill_ commentedThis is a straight forward upgrade, there are some white space and space/tab clean ups after running it through coder module as well.
This is based on HEAD as you can probably see.
Comment #2
thill_ commentedOk this time i cleaned some more coder warnings
Comment #3
BlakeLucchesi commentedThis isn't applying cleanly for me on either 6.x-1.x-dev or 6.x-1.x-beta1.
Comment #4
BlakeLucchesi commentedThe patch I've uploaded applies to the beta1 release. I have done some minor testing with it and can confirm that the video id and titles are importing properly.
Comment #5
thill_ commentedBlake,
Thank you for reviewing the patch I provided.
To clarify I said it was against HEAD not 6x dev or beta.
To apply the patch I ran
Then I moved the patch file into the module directory and ran
Is there something wrong with this workflow that I am missing?
Comment #6
thill_ commentedWe are working through some additional issues right now, will post a new patch.
Comment #7
mikejoconnor commentedStill needs a little work. Heres a new patch against HEAD
Comment #8
thill_ commentedOk this is working as expected, this is against HEAD and therefore uses the RSS version of the API feed.
This feed is a good test feed:
http://gdata.youtube.com/feeds/api/videos?max-results=10&alt=rss&orderby=published&author=day9tvComment #9
Niklas Fiekas commentedSubscribe.
Comment #10
BlakeLucchesi commentedSorry this isn't in a patch, but I added the following to the parser so that I could grab just the id of the video by running a regex over the full video url.
$watch is the full url of the video. $id later gets added to the $item array. Hope this helps.
Comment #11
wojtha commentedI've made big changes in HEAD today. Parser now supports both RSS and Atom feeds #1003580: Rewrite parsing method and code cleanup, support both Atom and RSS Youtube Feeds. (This was the D7 release blocker which mentioned thill_ in #6).
So patch needs to be ported to match the new HEAD.
Comment #12
thill_ commentedI am going to make a new patch, you should roll the current HEAD into 6--1 though so it is applied to the dev version and then HEAD will be for 7
Comment #13
wojtha commented@thill_ thanks, I backported latest changes from HEAD to 6--1 so HEAD could be now used for D7 port
Comment #14
thill_ commentedNot tested yet but this shouid be the basic port
Comment #15
thill_ commentedThis is now tested and working for both rss and atom.
Comment #16
wojtha commented@thill_: thx for the last patch, I tried myself and all basic features are working.
Commited to HEAD and new 7.x-2.x-dev release was created.