Comments

thill_’s picture

Status: Active » Needs review
StatusFileSize
new3.58 KB

This is a straight forward upgrade, there are some white space and space/tab clean ups after running it through coder module as well.

This is based on HEAD as you can probably see.

thill_’s picture

StatusFileSize
new5.13 KB

Ok this time i cleaned some more coder warnings

BlakeLucchesi’s picture

This isn't applying cleanly for me on either 6.x-1.x-dev or 6.x-1.x-beta1.

BlakeLucchesi’s picture

Version: 6.x-1.x-dev » 6.x-1.0-beta1
StatusFileSize
new4.03 KB

The patch I've uploaded applies to the beta1 release. I have done some minor testing with it and can confirm that the video id and titles are importing properly.

thill_’s picture

Blake,

Thank you for reviewing the patch I provided.

To clarify I said it was against HEAD not 6x dev or beta.

To apply the patch I ran

git clone git://git.drupalcode.org/project/feeds_youtube.git

Then I moved the patch file into the module directory and ran

 patch <993594-2.patch

Is there something wrong with this workflow that I am missing?

thill_’s picture

Status: Needs review » Needs work

We are working through some additional issues right now, will post a new patch.

mikejoconnor’s picture

StatusFileSize
new5.23 KB

Still needs a little work. Heres a new patch against HEAD

thill_’s picture

Version: 6.x-1.0-beta1 » 6.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new5.71 KB

Ok this is working as expected, this is against HEAD and therefore uses the RSS version of the API feed.

This feed is a good test feed:
http://gdata.youtube.com/feeds/api/videos?max-results=10&alt=rss&orderby=published&author=day9tv

Niklas Fiekas’s picture

Subscribe.

BlakeLucchesi’s picture

Sorry this isn't in a patch, but I added the following to the parser so that I could grab just the id of the video by running a regex over the full video url.

      // get video ID
      preg_match("/v=([a-zA-Z0-9_-]+)/i", $watch, $video_id_matches);
      $id = $video_id_matches[1];

$watch is the full url of the video. $id later gets added to the $item array. Hope this helps.

wojtha’s picture

Status: Needs review » Needs work

I've made big changes in HEAD today. Parser now supports both RSS and Atom feeds #1003580: Rewrite parsing method and code cleanup, support both Atom and RSS Youtube Feeds. (This was the D7 release blocker which mentioned thill_ in #6).

So patch needs to be ported to match the new HEAD.

thill_’s picture

Assigned: Unassigned » thill_
Priority: Normal » Major

I am going to make a new patch, you should roll the current HEAD into 6--1 though so it is applied to the dev version and then HEAD will be for 7

wojtha’s picture

@thill_ thanks, I backported latest changes from HEAD to 6--1 so HEAD could be now used for D7 port

thill_’s picture

StatusFileSize
new3.76 KB

Not tested yet but this shouid be the basic port

thill_’s picture

Status: Needs work » Needs review
StatusFileSize
new6.77 KB

This is now tested and working for both rss and atom.

wojtha’s picture

Status: Needs review » Fixed

@thill_: thx for the last patch, I tried myself and all basic features are working.

Commited to HEAD and new 7.x-2.x-dev release was created.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.