Due to the reversion in #497118: Remove the registry (for functions) the current 7.x-1.x nightly does not work.

The attached patch moves the hooks back into the .module files and adds a 'file' key to charts_menu. It also moves the settings page from admin/settings/charts to admin/config/charts.

CommentFileSizeAuthor
#5 charts-revert-registry-changes-942684-5.patch3.23 KBpillarsdotnet
#2 charts-revert_registry_changes-942684-2.patch4.76 KBpillarsdotnet
revert_registry_changes.patch7.77 KBmakononov

Comments

attiks’s picture

attiks commented
Status: Needs review » Reviewed & tested by the community

Patch works, thanks

To be sure I also ported the charts_system module to double check, see #960870: Port of charts_system to D7

pillarsdotnet’s picture

pillarsdotnet commented
Assigned: makononov » Unassigned
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new charts-revert_registry_changes-942684-2.patch4.76 KB

Re-rolled for current 7.x-1.x checkout, and moved config page to admin/config/content/charts.

pillarsdotnet’s picture

pillarsdotnet commented
Title: 7.x-1.x-dev breaks due to reversion of registry changes in core » Fix charts breakage due to #497118: Remove registry (for functions).
ccoppen’s picture

ccoppen commented

Can you re-roll this for the latest checkout please? It's not working against the latest dev.

pillarsdotnet’s picture

pillarsdotnet commented
StatusFileSize
new charts-revert-registry-changes-942684-5.patch3.23 KB

Straight re-roll; untested. Probably the contents of charts.hooks.inc should be moved into charts.module.

ccoppen’s picture

ccoppen commented

Message I'm getting after applying this latest patch:

Checking patch charts.hooks.inc...
warning: charts.hooks.inc has type 100755, expected 100644
Checking patch charts.info...
warning: charts.info has type 100755, expected 100644
Checking patch charts.install...
warning: charts.install has type 100755, expected 100644
Checking patch google_charts/google_charts.info...
warning: google_charts/google_charts.info has type 100755, expected 100644
Applied patch charts.hooks.inc cleanly.
Applied patch charts.info cleanly.
Applied patch charts.install cleanly.
Applied patch google_charts/google_charts.info cleanly.

Still no config options and the message that no charts provider is installed even though I enabled the Google charts.

pillarsdotnet’s picture

pillarsdotnet commented

Unfollowing because I no longer use this project in any of my sites.

mattbk’s picture

mattbk commented

I am getting this as well.

Still no config options and the message that no charts provider is installed even though I enabled the Google charts.

quicksketch’s picture

quicksketch
he/him
commented

Thanks guys. I've adopted this module and I'm working on whipping it into shape. Committed #5. Thanks @pillarsdotnet.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.