In #772690: Module revamp, it is mentioned that genpass_user_admin_settings_submit() has been removed because it was useless. On line 110 of genpass.module, $form[#submit][] is still set to 'genpass_user_admin_settings_submit'.

This raises the interesting question of why it is not being called. It seems to me that the module should break when Drupal attempts to call genpass_user_admin_settings_submit()...

(#372818: Form validation/submit handlers shouldn't automatically be skipped if button validation/submit handlers exist touches on submit handlers not being called, although the issue is not exactly what is happening here.)

In fact, if you try to run the module in Drupal 7, you have to remove the line altogether, as I did in #838406: GenPass: Drupal 7 port.

CommentFileSizeAuthor
#1 937160-1-remove-submit-callback-reference.patch692 bytesalberto56

Comments

alberto56’s picture

alberto56 commented
StatusFileSize
new 937160-1-remove-submit-callback-reference.patch692 bytes

Here's a patch which completely removes reference to the submit callback. Thoughts?

joelstein’s picture

joelstein commented
Status: Active » Fixed

Good catch! I don't know why Drupal wouldn't isn't throwing an error if the callback doesn't exist. It must check if the callback exists, but I haven't looked into it.

Committed in http://drupal.org/cvs?commit=443108

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.