better handling for exceptions

Subscribing.

Hi greggles,

Agreed, was definitely on my todo list to look at catching the exceptions and getting them into watchdog.

The actual output you've got there is a PHP error though, so it's showing the exception and the Xdebug stack trace output, so the exceptions are much shorter normally, we'd be storing something like this in watchdog -

Error while mailing. Postmark returned HTTP code 422 with message "Sender signature not found for email."

Which comes from the postmark.php class, I'll have a look at this and get something added in.

Thanks,

Luke

Had a look at this and think I've got the catching of exception set up OK now.

Basically the only throwing of exceptions happens in the send() method, so I've set up the $mail->send() to catch the exceptions and use them properly.

I've also moved the full print_r() of the exception to watchdog if debugging is switched on, to save from unnecessary watchdogging (not the best verb).

I've also added tidier drupal_set_messages, including one for if the value for "no credit use" is switched on, i.e. the script sends no emails, just returns TRUE.

Once again will roll these into next release once I've heard about the Postmark include.

Thanks,

Luke

subscribing, I also get this message when the module is disabled. Should I uninstall it to get rid of the messages?

OK I've sorted this and it's available in the latest release.

zilverdistel - as per the other issue related to your point #1004340: When postmark is disabled, drupal still tries to send email through postmark I've modified the disable/enabled checking for smtp_library, so you shouldn't get this anymore as if the module is disabled then the SMTP being used should be the default library not Postmark.

Since Drupal 6 is EOL a long time ago, I am closing this. Feel free to re-open if still relevant.