This would make it much easier to find duplicates - as it is now have have to page through many pages to track down dupes. Some additional sorting throughout the modules various reports would make it much more usable.

Thanks!

CommentFileSizeAuthor
#6 page-title.png82.07 KBlocomo
#6 meta-node1.png85.88 KBlocomo
#6 meta-node2.png94.98 KBlocomo

Comments

kristen pol’s picture

Assigned: Unassigned » kristen pol

Good idea... I'll see if I can figure out how to do that.

Kristen

kristen pol’s picture

p.s. If you want to, you can also show more results per report by changing the setting "Report Pager Number" on the bottom of:

http://[domain]/admin/content/seo_friend/default

Cheers,
Kristen

locomo’s picture

cool - thanks

kristen pol’s picture

I'm working on it right now and hope to have it out soon!

Kristen

kristen pol’s picture

Status: Active » Fixed

I've checked in the changes. I've made all columns on the meta tags (node) report and page title report sortable that make sense.

It will be in the next dev release from the drupal cron. Please test and let me know if it is working as desired.

Thanks,
Kristen

locomo’s picture

StatusFileSize
new94.98 KB
new85.88 KB
new82.07 KB

hmm.. this is behaving strangely for me

in the page title report the "duplicates" column is now sortable (and grey) but there are no values in the field

in the meta tag (node) report is also sortable (and grey) but i'm not really sure what its sorting on ..

i've attached screenshots

thanks!

kristen pol’s picture

Hmmm... it shows up for me. Can you try flushing your cache? I wonder if something is conflicting with your theme. I'm using the standard Drupal sortable table stuff, so not sure why it's not working for you. Do other sortable tables work for you?

Btw, the meta tags sort should sort by color (pink=error, green=ok)... not obvious but thought it would be useful to sort by that while I was in there.

Kristen

locomo’s picture

strange.. i flushed my cache and tried Garland.. but it still doesn't seem right .. i also checked the table in admin/user/user and that table is sorting properly

i think the sort by color is a great idea.. i'm not sure why the "duplicates" column in grey in my setup and has no values - and i'm pretty sure that i still have errors because I did on the previous dev version and i hadn't gotten around to fixing them all yet

also, in meta tag (node), what do you mean by:
"tag value duplicates"

kristen pol’s picture

I just realized that the duplicates column is empty because you have no duplicates ;) If you did, the row would be pink and you don't have any pink rows.

Not sure about the meta tags table though... did it always look like that? Do those nodes have meta tag data?

Kristen

kristen pol’s picture

Status: Fixed » Postponed (maintainer needs more info)

Are you using an older version of nodewords?

What do you see for the meta tags (node) report if you use the beta6?

Kristen

locomo’s picture

i'm actually using the dev version of nodewords.. but not the most recent

so that might be the problem

i just checked and i do in fact have duplicates and they show up pink if i page through to find them.. but if i sort that column the entire column goes gray and nothing actually gets sorted

but i wouldn't want you to waste much time on my account if its related to nodewords.. that module seems to change so much with each dev release that it might not be worth chasing down

kristen pol’s picture

Could be nodewords conflict or could be because of the pager. What if you set the number to show on the reports to a big number so it shows everything? You can configure that at:

http://[domain]//admin/content/seo_friend/default

go to bottom and change "Report Pager Number" to a big number (e.g. 1000).

Kristen

kristen pol’s picture

It is a pager issue... I just tested by making my pager number a small number. I had duplicates but when I set the pager number small, it didn't show the duplicates because they were on separate pages.

So... for now, if you increase the number shown, that should be a temporary fix. Meanwhile I'll need to figure out how to indicate duplicates even if the other duplicate isn't on the current page... and figure out how to get the duplicates to sort properly across multiple pages.

Thanks for testing,
Kristen

locomo’s picture

confirmed.. temporary fix of increasing the number of records to return to a large number works

ptitb’s picture

I still experience problems when I want to sort on "meta tags" on the Meta Tags (node) report.
Even when I increase the number of records to return.

There is no logic on what it sorts; they don't sort on color.

Any ideas?

Thanks,

Peter

kristen pol’s picture

Unfortunately I was trying to piggyback off of the core drupal table sorting which requires that the sorting be based on a database query field. That works for the other columns (e.g. title) but doesn't for the "duplicates" column since there is not a one-to-one mapping between a query field and the results in that column.

I will likely have to get rid of the sorting on that column for now until I can find an alternative sorting mechanism... :(

Maybe there is a jquery table sorting library I could leverage... I'll have to do some research.

Kristen

kristen pol’s picture

I have found a tutorial on adding table sorting using jquery: http://www.exforsys.com/tutorials/jquery/jquery-basic-alphabetical-sorti...

Unfortunately I've got limited time right now and will be away for a month in Chicago/Evanston, so I won't be able to play around with this until around August.

If anyone knows jquery and wants to try creating a patch, feel free!

:)Kristen

kristen pol’s picture

Status: Postponed (maintainer needs more info) » Closed (won't fix)

I have backed out the sorting for the duplicates & meta tags column. I haven't had time to investigate the jquery method and don't think I'll have time to look into this any time soon.

I would welcome a patch if anyone wants to work on this.

Kristen

kristen pol’s picture

Assigned: kristen pol » Unassigned
Issue summary: View changes

cleaning up my issues list