I looooooove this module for Drupal 6.
And I'm shocked no one has yet created an issue to port it to Drupal 7.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | insert_drupal6.patch | 5.52 KB | quicksketch |
| #2 | insert_drupal7.patch | 30.49 KB | quicksketch |
I looooooove this module for Drupal 6.
And I'm shocked no one has yet created an issue to port it to Drupal 7.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | insert_drupal6.patch | 5.52 KB | quicksketch |
| #2 | insert_drupal7.patch | 30.49 KB | quicksketch |
Comments
Comment #1
quicksketchHeh, well it was bound to happen sooner or later. ;-)
This should be a fairly easy port, but I've got other modules I'm committed to porting (most notably Flag), so this may take backseat. Then again, it's easy so maybe I'll do it first while I put off porting Flag.
Comment #2
quicksketchI've branched HEAD for Drupal 7 development and put in these patches to get a start on Drupal 7. This required some file renaming, since I had to remove references to ImageField, FileField, and ImageCache and replace them with Image and File references and namespaces.
This patch also includes some trickery to get images to load at the final URL, since Image module in Drupal 7 actually uses a temporary path at "/system/generate/..." for creating image derivatives. Because we need to use the final, real URL when inserting images inline, I had to create a few menu entries to maintain this behavior. It will likely have problems (such as when the the Image style is modified and the derivatives are deleted). We can solve that in a later issue.
Also attached are changes to the Drupal 6 version that have been made for consistency between the two branches.
Comment #3
quicksketchI've opened a follow-up issue at #785980: Images may disappear when editing Image styles for the problem with Image style inserts. Please open new issues for any new bugs or problems found in either the Drupal 6 or Drupal 7 versions of Insert.