In the function covert_fields_widget(), error handling code ensures that the Covert Fields module is only handling a widget it recognizes. Unfortunately, if the error handling code is ever actually invoked, the error message will be "covert_fields does not know how to handle widget type """, which isn't very helpful. The cause is that $widget['type'] should be $field['widget']['type'].

The attached patch corrects this subtle bug. The good news is that the erroneous code would almost certainly have never been invoked, but the bug does show up if you're creating a new module based off of Covert Fields and a widget is named improperly.

CommentFileSizeAuthor
covert_fields_widget_error.patch445 bytesguypaddock

Comments

john.karahalis’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the patch, Guy. I've committed this and will be releasing Covert Fields rc3 shortly.

john.karahalis’s picture

Status: Reviewed & tested by the community » Fixed

rc3 released. Thanks for being awesome, Guy.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.