After enabling the new module, I received 1500 emails letting me know there was an avatar ready tor approval.
No PHP errors recorded, but ran the server out of memeory using thousands of sendmail requests.

Comments

gregarios’s picture

gregarios commented

All I did was install the module, run the update.php, set the "Approval queue length threshold" to 1 so I'd get an emaiul when a new avatar was posted, then updated one of my users' avatars. Instantly sendmail was screaming out of control and my inbox had 500+ emails in the first 12 seconds. I had to reboot the server and clear the mqueue for sendmail just to get back up and running. (-;

I should mention that I use Reroute Email module on my sandbox site to keep my users accounts from getting email from it, so the email could have been sent to all of my users, then got rerouted to me (admin) or it could have just been sent to the admin email 1500 times. ;-) Either way it isn't working.

dalad’s picture

dalad commented

I apologize for the spam bomb :P... substitute around line 330 of avatarapproval.module
from

$result = db_query("SELECT u.* FROM {users} u

to:

$result = db_query("SELECT DISTINCT u.* FROM {users} u

And please keep testing. Patch will follow soon. Thanks for your patience

dalad’s picture

dalad commented
Version: 6.x-1.0-beta2 » 6.x-1.0-beta3
Status: Active » Fixed
gregarios’s picture

gregarios commented

Much better. Thanks! Like the new email feature. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.