| Comment | File | Size | Author |
|---|---|---|---|
| #12 | spamspan-mailto_images-723460-12.patch | 4.39 KB | vitalie |
| #10 | spamspan_images_723460_10.patch | 744 bytes | tomb-2 |
| #9 | spamspan-images-723460-9.patch | 2.54 KB | Anonymous (not verified) |
| #7 | spamspan.js_.patch | 1004 bytes | DizzySquirrelz |
Comments
Comment #1
radiobuzzer commentedSorry code was filtered. Let's try again
Comment #2
josdberd commentedSubscribing
Comment #3
deleron commentednot tested so I will not create a patch:
In spamspan.js (line 34), replace:
with:
Using .text() discards the
tag, using .html() keeps it.
Of course, to work, you have to compress again the spamspan.js file into spamspan.compressed.js
Hope this help.
Comment #4
lakka commentedFixed in 6--1.5. Thanks.
Comment #5
lakka commentedReviving this bug. The fix applied did not work when there was no nested element within the <a> tag, so I have removed it.
Comment #6
DizzySquirrelz commentedThe fix also overrides the image alignment when linking the image to an email.
Comment #7
DizzySquirrelz commentedI have created a patch which solves the problems above.
The code first checks if an image is present and then utilizes .html (keeping the img tag in place) otherwise it just uses .text
There is still the issue where the filter_xss() function in spamspan.module throws out any styling inserted by wysiwyg, such as: style="align:right;"
So for that I replaced (Line 224):
$output = filter_xss($output, $allowed_tags = array('em', 'strong', 'cite', 'b', 'i', 'code', 'span', 'img'));with:
//$output = filter_xss($output, $allowed_tags = array('em', 'strong', 'cite', 'b', 'i', 'code', 'span', 'img'));This disables the filter, but then also presents a security risk. I am not too sure how to get around this one yet.
Comment #8
Anonymous (not verified) commentedThanks for the patch, DizzySquirrelz! I can confirm that this is working for me.
Maybe we can get this into a release? Seems like an important feature.
Comment #9
Anonymous (not verified) commentedFound an issue in IE < 9 where the round brackets weren't being properly removed on output. I was able to use the same technique from ln 28 of spamspan.js to fix it by adding ?'s to the code:
.replace(/^ ?\((.*)\) ?$/, "$1");I've rerolled the patch from #7 with changes included.
Comment #10
tomb-2 commentedRe-rolled the patch in #9 for version 7.x-1.1 beta 1
Comment #11
tomb-2 commentedComment #12
vitalie commentedThanks all for the patches. I have integrated the main idea of the patches in the patch below. In addition it deals with the fact that latest 7.x.-1.x dev code is first converting images to
<!-- img $hash -->and then puts them back.Comment #14
vitalie commentedComment #15
NaX commentedI don't know what happened, this was fixed in D6-1.5 but reverted in D6-1.6. When you compare the to version the 1.6 is reverted back to using the .text() method rather than the .html() method.
Can we maybe get this committed to the D6 branch and then get a new release.
Comment #16
anybody