Here's my setup: most recent versions of mailcomment and mailhandler. I want people to send a mail to "discuss@example.com" to start a thread, and when mail goes out the responses should be to "discuss@example.com" as well. So, the Mailhandler mailbox setting for discuss@example.com is to use mailcomment default authentication and the mailcomment setting is set to use "Passthru to mailhandler module."
The problem seems to be that when the message is passed through it tries to do a node_access test, but that returns false b/c the $node->uid is 0. I think that we need an option in "Passthru to mailhandler module" to select the mailhandler authentication mode to use.
I was able to get around this by calling mailhandler_authenticate_default right before the node is returned in mailcomment.module line 349 for the passthrough option.
Is there a better way of doing this? Should I provide a dropdown in the the Mailcomment "Passthrough" area to select the backup auth method?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 713038-4-mailcomment.patch | 2.52 KB | Ian Ward |
| #2 | 713038-2-mailcomment.patch | 1.9 KB | Ian Ward |
Comments
Comment #1
Ian Ward commentedGreg, I see what you're saying. This is some regression. The default authentication method for MC uses mailhandler's tokenauth plugin. I thought about the idea of having authentication methods stackable on mailhandler mailboxes. You could choose one or more authentication methods, weight them, and they would get run if the previous fails. There'd need to be a failure flag. I was hesitant because it's an additional level of complexity in terms of user configuration, but seems straight-forward in terms of implementation. This would make it possible to strip out the hard-coded tokenauth fallback in the mailcomment authentication plugin. What do you think about this?
Comment #2
Ian Ward commentedOn second thought, stackable authentication plugins is more complication than worth dealing w/ on the current mailhandler API. We could make this an additional setting in mailcomment that allows for using the default mailhandler authentication (email address verification). Basically what you're suggesting, Greg, but not giving the option to choose other methods. I'd like to get mailhandler running on ctools and use its plugin API and then look at doing the option of multiple, stackable authentication plugins per mailbox. What do you think of the attached patch?
Comment #3
gregglesYour proposed patch in #2 seems pretty good to me and in my testing it works fine.
I'm not as sure whether it should be a "yes/no" radio button as now or a dropdown that follows the contents/behavior of "Message authentication method" from admin/content/mailhandler/edit/1
Comment #4
Ian Ward commentedIt may as well just be a select list as you originally wrote. I've attached a patch.
Comment #5
gregglesVisually this looks great and in my testing (of the default Mailhandler auth method, nothing fancy) it works.
Comment #6
Ian Ward commentedThanks again Greg, marking fixed.