Hi,

I would like to report two bugs in tinymce-node-picker-page.tpl.php:
1.) print $tabs; is surrounded by

    , because $tabs already contains

      , it is printed twice and thus yield incorrect HTML.
      2.) The template contains

      , I suggest moving the attribute id="nodepicker" to the body element. In that way it's easier to style the popup. For example, in our site's theme the background is colored, but that behavior is undesired for popups. Now I'm only able to change the background of the
      element and not the complete body.

      I've attached a patch which solves these issues.

      Thanks in advance.

      CommentFileSizeAuthor
      page.tpl_.patch308 bytesRobbert

      Comments

      Robbert’s picture

      Robbert commented

      I forgot to press the "preview" button of my bug report whence I didn't see that I have forgotten to escape my code properly. Unfortunately I'm unable to edit, so let me repost my message such that it makes sense. My apologies.

      1.) <?php print $tabs; ?> is surrounded by <ul class="tabs primary"></ul>, because $tabs already contains <ul class="tabs primary"></ul>, it is printed twice and thus yields incorrect HTML.
      2.) The template contains <body><div id="nodepicker">, I suggest moving the attribute id="nodepicker" to the body element. In that way it's easier to style the popup. For example, in our site's theme the background is colored, but that behavior is undesired for popups. Now I'm only able to change the background of the <div> element and not the complete <body>.

      peter törnstrand’s picture

      peter törnstrand commented
      Assigned: Unassigned » peter törnstrand

      Sounds reasonable. Will fix.

      peter törnstrand’s picture

      peter törnstrand commented
      Status: Active » Fixed

      Status: Fixed » Closed (fixed)

      Automatically closed -- issue fixed for 2 weeks with no activity.