I have used draggableviews on a few sites now without problems but using the betas.

I started on a new site in the last few days and all of a sudden I am having trouble. Every time I edit the style settings it does not seem to keep its settings.

It seems to save the settings but the form seems go back to defaults every time I edit the settings.

Drupal 6.15
DraggableViews 6.x-3.3
Views 6.x-2.8
Content 6.x-2.6

After some digging I changed the following in draggableviews_plugin_style_draggabletable.inc in function options_form()

From:

    // Check for input.
    if (count($input) > 0) {
      // Define the input data as the current data.
      $current = $form_state['input']['style_options'];
    }
    else {
      // Define the already stored data as the current data.
      $current = $this->options;
    }

To:

    // Check for input.
    if (count($input) > 0) {      
      // Define the input data as the current data.
      $current = $form_state['input']['style_options'];
    }
    if (!$current) {
      // Define the already stored data as the current data.
      $current = $this->options;
    }

And this seems to fix the problem but I don’t know why this is happening or if this is a workaround rather than a fix.

CommentFileSizeAuthor
#11 draggableviews-677886-2.patch854 bytessevi
#11 draggableviews-677886-1.patch763 bytessevi
#11 draggableviews-677886-the-fatal-change.patch666 bytessevi
#9 draggableviews.patch1.04 KBseanr

Comments

bleen’s picture

bleen commented

+1

I'm having this issue as well

bleen’s picture

bleen commented

+1 for the fix described in the original post - it seems to work fine

sevi’s picture

sevi commented
Status: Active » Needs work

Mmm.. something must have changed in views.
With views 6--2-7 everything works fine.
With views 6--2-8 I see the problems you described.

You've to refresh the html UI-page after updating views before you can see the effect. Thus the fatal change must be somewhere in the javascript-settings.

I couldn't find the significant change yet. At the moment I don't have time to dig deeper. Maybe someone can find the significant change in views.
This would help me understanding why things don't work now.

Thanks,
Greetings,
sevi

seanr’s picture

seanr
he/him
commented

Same issue here. Seems like a bug in views. Should we submit a separate issue there or change this one to views instead?

sevi’s picture

sevi commented

I'm not yet sure whether this is a bug of views. I'll probably find some time on Wednesday to get things straight.

NaX’s picture

NaX commented

@sevi
When I first discovered the problem it looked like $form_state['input']['style_options'] was not being set. I hope that helps.
I don’t know of any API change on the Views 2.x branch. Maybe this is a bug in Views.

seanr’s picture

seanr
he/him
commented

I went ahead and posted a separate issue in the views queue to try to find out what they changed:

#682610: Some module-defined view style settings don't save

dawehner’s picture

dawehner
Primary language German
commented

You missed to define a lot of variables in option_definition. I think you need this to store all this values.

seanr’s picture

seanr
he/him
commented
StatusFileSize
new draggableviews.patch1.04 KB

Afters some debugging, it looks like the problem is occurring down at line 145 where $current is defined. After commenting out everything in that block of code except for $current = $this->options;, everything works perfectly. See attached.

The only trouble is that the order doesn't save when I go to the page, reorder the items, and click save order. I don't think that's related to this patch, though (I always have a hellish time getting these views to work right).

seanr’s picture

seanr
he/him
commented

Figured out my other problem - view works perfectly now with just the patch in #9. BTW, the change in the initial post wouldn't work because $current does get populated, but with only one of the field values instead of all of them. I'm honestly not sure why that whole if statement was ever needed in the first place.

sevi’s picture

sevi commented
Status: Needs work » Patch (to be ported)
StatusFileSize
new draggableviews-677886-the-fatal-change.patch666 bytes
new draggableviews-677886-1.patch763 bytes
new draggableviews-677886-2.patch854 bytes

Got it.
The first patch shows the fatal change of views. IT IS NOT A BUG OF VIEWS.

The second and third patch applies to draggableviews.module and views/draggableviews_plugin_style_draggabletable.inc. They make things working again :)

Greetings,
sevi

sevi’s picture

sevi commented

Afters some debugging, it looks like the problem is occurring down at line 145 where $current is defined. After commenting out everything in that block of code except for $current = $this->options;, everything works perfectly. See attached.

E.g. when you add a new node type at the draggableviews-settings (the "Add type" button) the options-form gets updated without saving the values. Here we need to use the input values instead of the saved values -> Your patch would fail in this situation.

sevi’s picture

sevi commented
Status: Patch (to be ported) » Active
NaX’s picture

NaX commented
Status: Active » Reviewed & tested by the community

@sevi
I have tested and confirm that you patch’s from #11 worked for me.

sevi’s picture

sevi commented
Title: Loosing settings » Loosing DraggableViews style plugin settings after upgrade from Views 6.x-2.7 to Views 6.x-2.8
Status: Reviewed & tested by the community » Fixed

@sevi
I have tested and confirm that you patch’s from #11 worked for me.

Great, Thanks.

Committed patches

  • draggableviews-677886-1.patch from #11 and
  • draggableviews-677886-2.patch from #11

to DRUPAL-6--3 branch.

Changed title for findability.

Greetings,
sevi

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.