I wasn't sure if this is really needed or not, but since gmaplocation creates 13 variables, I thought I'd toss an uninstall function out for consideration.

CommentFileSizeAuthor
gmaplocation_install.patch616 bytesJaredAM

Comments

JaredAM’s picture

JaredAM commented
Status: Active » Needs review

I keep forgetting to mark these things as needs review... ;)

babbage’s picture

babbage commented

That's a definitely-required, hadn't noticed it didn't have an uninstaller when I inherited it... That's almost a bug. Will review.

babbage’s picture

babbage commented
Status: Needs review » Fixed

Commit #424344 by dbabbage at 22:10:
#626490 by dbabbage and JaredAM: Add uninstaller.

In the end, I didn't use your exact implementation, JaredAM, as I figured it was cleaner to user the API function variable_del (http://api.drupal.org/api/function/variable_del). However, this wouldn't have happened without you posting the patch in the first place. Thanks for that, and again as with the other patch my apologies this languished for so long after your work.
:)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.