There are some issues with the JS posting the correct information. Patch is prepared.

CommentFileSizeAuthor
#4 community_tags_js.patch2.2 KBstackpr
fix_serialize.patch2.25 KBstackpr

Comments

entrigan’s picture

entrigan commented

What do you mean "tags that are sub-strings"? Like if I have one tag: "abcd", and then I try to tag "abc"?

Thanks :)

entrigan’s picture

entrigan commented
Status: Patch (to be ported) » Needs review
chaps2’s picture

chaps2 commented
Status: Needs review » Postponed (maintainer needs more info)

I can't reproduce this. @witti - I've gone with entrigan's interpretaion in #1 for which there doesn't seem to be a problem. Could you give more details please?

stackpr’s picture

stackpr commented
Title: JS does not handle tags that are sub-strings » JS does not handle tags with special characters (e.g., ampersands)
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new community_tags_js.patch2.2 KB

I do not recall the specifics of how it impacted substrings. However, the patch changes how ampersands are encoded for the POST -- try a test with a tag like "test & test". I do not see any obvious problems with substrings, so that can probably be disregarded. Also, the patch is cleaned up slightly now. If ampersands are treated how you want them to be handled, feel free to close.

chaps2’s picture

chaps2 commented
Status: Needs review » Fixed

Thanks for looking into this again after more than 12 moths and thanks for the patch. In the end I fixed it by replacing calls to Dupal.encodeURIComponent (for paths only) in Drupal.serialize with the standard JS encodeURIComponent. I also name-spaced Drupal.serialize whilst I was there.

Committed and included in new releases 7.x-1.0-beta2 and 6.x-1.0-beta5.

stackpr’s picture

stackpr commented
Status: Fixed » Closed (fixed)