I've patched ad_flash.install to use schema API, which should enable Flash Ad to support PostgreSQL, as Ad already supports it.

There is a completely untested (but simple) hook_update_N function for current MySQL users that should get them along.

On a sidenote, I removed all existing copyright markings that claimed “all rights reserved”, as all drupal.org -hosted code is supposed to be GPL'd.

CommentFileSizeAuthor
#4 ad_flash.install.head_.patch5.6 KBaaron1234nz
ad_flash_schema_api.patch6.01 KBplj

Comments

chriscohen’s picture

chriscohen commented

Thanks for doing this. I will check it out! Any other testers would be appreciated.

Alex Andrascu’s picture

Alex Andrascu commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Assigned: Unassigned » Alex Andrascu

Please reroll this patch on the current HEAD version and i'll commit it. Thank you.

Alex Andrascu’s picture

Alex Andrascu commented
Status: Needs review » Needs work
aaron1234nz’s picture

aaron1234nz commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new ad_flash.install.head_.patch5.6 KB

Rerolled against HEAD and tested on postgres.

Alex Andrascu’s picture

Alex Andrascu commented

Commited in 2.5 (wrong commit) then in 2.6 please check if everything's ok. And thanks again for the patch. Looks pretty and clean now with the Schema API.
Alex

Alex Andrascu’s picture

Alex Andrascu commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.