Closed (fixed)
Project:
Usercount
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
5 Sep 2009 at 05:04 UTC
Updated:
14 Feb 2015 at 22:04 UTC
Jump to comment: Most recent
The code is not following drupal coding guidelines to include all tables in curly brackets.
E.g
select count(*) as count from users where status = 1 and login != 0
Need to be
select count(*) as count from {users} where status = 1 and login != 0
This is not just a purist point. If you have tables with prefix defined, the module does not work due to above issue.
Comments
Comment #1
yelvington commentedYou're right. I thought I had fixed that. I'm traveling right now; will look at this when I get back.
Comment #2
ken hawkins commentedJust dove into the code. Looks like they're all fixed except for one in the "usercount_blocked" function.
At line 163
Comment #3
yelvington commented