This is a great module. But I ran into trouble when I started using a postgresql database. The queries have all these ` characters in them, which are only used in mysql, and they serve no purpose here except to make the queries incompatible with postgres.

This is a patch that takes the ` characters out.

CommentFileSizeAuthor
#2 hkey.diff10.08 KBgalaxor
hotkey_postgres.diff8.61 KBAnonymous (not verified)

Comments

smokris’s picture

smokris
Location Athens, Ohio, USA
commented
Assigned: Unassigned » smokris
Status: Needs review » Fixed

Committed. Thanks. This will be part of 6.x-2.1.

galaxor’s picture

galaxor commented
Version: 6.x-2.0 » 6.x-2.1
Priority: Normal » Critical
Status: Fixed » Needs work
StatusFileSize
new hkey.diff10.08 KB

It turns out there was a reason for the ` characters. In mysql, the word "key" is a reserved word. In hotkeys, there's a column called key. Therefore, if we don't quote the name `key`, then none of the queries work.

Here is a patch that changes the name of the `key` column to hkey, and then uses the column with that name, which is safe in postgres and mysql.

smokris’s picture

smokris
Location Athens, Ohio, USA
commented
Status: Needs work » Fixed

Thanks, @galaxor. I revised the patch slightly, to use update_sql instead of the "useless field" hack, and applied it. It's part of the 6.x-2.2 release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.