I find the subscription module useful for users, but notify excellent for site editors. Is there a chance of getting postgres support for this module?

CommentFileSizeAuthor
#5 notify_6.patch3.81 KBmarkstos
#3 notify.patch.tar_0.gz1.28 KBttt
#1 notify.patch.tar.gz892 bytesttt

Comments

ttt’s picture

ttt commented
StatusFileSize
new notify.patch.tar.gz892 bytes

I've ported the 4.5.0 code to postgresql. In the attached tar.gz file, you'll find two files:

  • notify.pgsql - the table definition and a function for inserting/updating the table
  • notify.inc - changed "REPLACE" with the custom insert/update function
ttt’s picture

ttt commented

Uh, I acted before testing... Actully there're still 2 queries in notify.inc that need to be fixed. Please discard the patch.

ttt’s picture

ttt commented
StatusFileSize
new notify.patch.tar_0.gz1.28 KB

Here's an updated patch for PostgreSQL support.

hystrix’s picture

hystrix commented

Thank you, the 4.5.0 version is working for me with the schema and patch found on this dupe issue 19462.

markstos’s picture

markstos commented
Version: » 4.6.x-1.x-dev
Assigned: Unassigned » markstos
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new notify_6.patch3.81 KB

I have attached a patch which adds PostgreSQL support in a SQL standard way, so MySQL support should continue to work as well. (But needs testing to verify that). There should just need to be one code and sql file that works with both now.

The patch is comprehensive and and also includes updating the INSTALL and Changelog files as well.

I tested this successfully with:

PostgreSQL 8.0
Drupal 4.6.3

RobRoy’s picture

RobRoy commented

Take a look at the .install file in HEAD and let me know if the PostgreSQL syntax is good to go.

RobRoy’s picture

RobRoy commented
Status: Reviewed & tested by the community » Closed (fixed)