Closed (fixed)
Project:
Pageroute
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
5 Aug 2009 at 10:23 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
fago* Please watch out for tabs, you have quite some of them in your patch. Also always have a look on your patches before posting them, so you can identify wrong changes beforehand yourself.
* Doing a PagerouteTestCase looks fine, however the file should just be pageroute.test.
* The static getInfo() function should not make use of t() calls. (Yes that's quite new, but let's follow that.)
* It's fine that you test each page, but it's also important that clicking through the route works. Best also add a test function that tests that - so you can also test that the route's redirect target is right once you have finished the route.
Comment #2
sepgil commentedAll issues should be corrected and I made the requested test that clicks through the route.
Comment #3
fagoI removed the debug message that was left and committed it, thanks :)
Please watch out for removing any debug message for future patches.
Comment #4
sepgil commentedSince the Tabs and Node Management page types were removed(http://drupal.org/node/558862), I hade to update my simpletests.
Comment #5
sepgil commentedSorry, attached the wrong patch in the last post.
Comment #6
fagohm, I tried to run the tests with the recent dev-snapshot but it ran into several problems:
286 passes, 26 fails, and 3 exceptions
Also you missed a debug statement.
Comment #7
fagoComment #8
sepgil commentedfixed some issues and improved the simpletests...
Comment #9
fagothanks, committed. Now they are working again :)