Notification emails are not sent when "Both" is selected and "Send notifications to this custom email address:" is filled with some role(s) selected. The user who tries to register gets error message and knows nothing what it means and how he should address it. Some users tries to re-register, some leave the site for good.

Current work-around - do not use "Send to both" option.

CommentFileSizeAuthor
#5 urn_both.2.patch2.32 KBiva2k
#1 urn_both.patch2.28 KBiva2k

Comments

iva2k’s picture

Status: Active » Needs review
StatusFileSize
new2.28 KB

Attached is a patch that:
1. addresses that issue of "Send to both" giving error message to register user.
2. Removes duplicate email addresses from send to list, if any
3. Removes empty log message that carries no meaning

rmiddle’s picture

I need to do some testing. I don't see anything wrong with the patch but it will only catch duplicate addresses if you only enter 1 custom address. It will catch dupes but if you enter several emails all separated by comma's it wont work.

rmiddle’s picture

Issue tags: +Roadmap
rmiddle’s picture

Status: Needs review » Reviewed & tested by the community
iva2k’s picture

StatusFileSize
new2.32 KB

Oh, I see, you're right - it won't catch duplicates if there are multiple addresses in the "Send notifications to this custom email address:" field. I know how to fix that though. New patch attached. The trick is using preg_split():

$emails = preg_split('/,[\w]+/', variable_get('user_register_notify_mailto', $from));
iva2k’s picture

Status: Reviewed & tested by the community » Needs review
rmiddle’s picture

Committed to CVS. Will be in the 6.x-1.11.

Thanks
Robert

rmiddle’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Roadmap

Automatically closed -- issue fixed for 2 weeks with no activity.