Destination Token error

From what I can tell, the str_replace() in the patch will never actually replace anything, so that line could just as well be written as:

$destination_path = $node->{$field_name}[$field_instance]['filename']

Also, I'm not sure how $node->{$field_name}[$field_instance]['filename'] could work as a destination path for this file, as it is a new file being created, not an existing one being overwritten.

Please explain.

I can see that here might be a problem with file path tokens not being expanded. There might be some hooks that this module fails to invoke before saving new files. If someone wants to investigate this they are more than welcome!

First, I see you point about the file path in the first patch. (I misread the patch before.) This is probably a good change.

The second patch is harder to overview. It seems to deal with a lot of different things at the same time. I would prefer separate issues for each problem/task:

1) Whitespace/coding style changes.

2) Hm, isn't there already a different issue for this:

-  // TODO: Add option to hide original files.
+  $form['field'][$form_item_id]['hide_original'] = array(
+    '#type' => 'radios',
+    '#options' => array(t('Show All'), t('Hide Original')),
+    '#title' => t('Display'),
+    '#weight' => 10,
+    '#default_value' => $default_field_setting['hide_original'], 
+  );

Also, I think a #description would probably be useful.

3) The changes in ffmpeg_converter_nodeapi() – are these only related to 4)?

4) The split of the conversion and snapshot generation jobs is a good idea, and I really appreciate your efforts on this. I just find the patch a little hard to follow right now, for the reasons mentioned above.

To sum up, let's consider the first patch RTBC, and then create separate issues for 1) through 4), OK?

Committed the patch in the original post, with the addition of a modified code comment. Thanks!