Hi jabapyth,

I´m using moduleinfo for the last months, and I can see a reduction of the performance (in my development environment ). Today I solved my problems disabling moduleinfo.

Calling to the same page:
Execution time with moduleinfo: 24925.12 ms
Execution time without moduleinfo: 3820.76 ms

Moduleinfo slow down the site in more that 6 times!!!

I discover that moduleinfo is executed on every page call, not only for the module list page. And then, the more modules you have, the more time consuming.

Hope this can help you.

Regards,

CommentFileSizeAuthor
#4 moduleinfo.patch583 bytesmikeytown2
#3 moduleinfo.patch2.9 KBmikeytown2
#1 moduleinfo.patch2.87 KBmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new moduleinfo.patch2.87 KB

I made a quick patch for this issue, sorta a brute force way. Something is calling one of the sub functions thinking it is a hook, thats my guess as to why it gets executed on every page.
if ("admin/build/modules" == $_GET['q']){

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new moduleinfo.patch2.9 KB

here's a better one.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new moduleinfo.patch583 bytes

K I think I fixed the issue without the ugly.

dkruglyak’s picture

dkruglyak commented
Category: feature » bug
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Hmmm... Why is this still not committed? This bug is lethal if you have hundreds of modules in your filesystem.

I found the same problem and developed the same patch independently, but looks like you have it there already. Please commit ASAP!

jean-bernard.addor’s picture

jean-bernard.addor commented

I have not tested the patch, but I confirm extreme performance degradation which can even make difficult to disable the module. I have more than 100 modules, and no other choice as to disable the ModuleInfo module.

jabapyth’s picture

jabapyth commented
Status: Reviewed & tested by the community » Fixed

Sorry about that. Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

capellic’s picture

capellic
he/him/his
Location Austin, Texas
commented

@rsantiag --- thanks so much for figuring this out. All my sites were slow and I couldn't figure it out. I was suspicious of my hosting provider.