Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.We have a multilingual website (6 languages). We try to add all translations before the final sending, this is not always possible though.
When we haven't translated an issue yet, it gets sent to everybody in default English. It can't be sent twice. This is perfect!
However, AFTER we have sent it, we add the new language.
In English it still shows as sent, perfect.
In the new language it now can be sent again, this is not necessary but acceptable.
HOWEVER!!! When the editor accidently hits "SEND" again, ALL languages get sent to EVERYBODY again!
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | simplenews.372430_1.patch | 16.46 KB | sutharsan |
| #1 | simplenews.372430.patch | 20.74 KB | sutharsan |
Comments
Comment #1
sutharsan commentedTo solve this in a decent manner I made some UX changes:
- newsletter taxonomy term is now required (always, not only before sending)
- translated newsletters don't have send and format options, but depend for this on the translation source.
I'm not yet convinced this is the best solution, but it limited the complexity of the code. Feed back is appreciated, testing is a must!
Comment #2
Sophia commentedI'll test it later, thanks Sutharsan! If it works you're my hero :)
Comment #3
Sophia commentedWell, I admit defeat, I tried and tried to apply the patch on my own computer and on cpanel, but somehow I can't manage to do it :( Could you give a find & replace instead, so I can manually update the file? I really wish to test this... sorry about that!
Comment #4
Sophia commentedThanks, I got your message Erik. I tested, created a newsletter in various languages, and indeed, I could not send it from any of the translations. However when I actually sent them, one the newsletter languages arrived saying "Unassigned newsletter". I checked, and the newsletter was definitely chosen. I don't think it is ready to go live... yet :)
Edit: I forgot to mention that that particular test account was set to "receive plain text email only", don't know if that could have anything to do with it.
Comment #5
sutharsan commentedWith this patch it should work fine. Note the patch is against 6.x-1.x-dev.
Comment #6
Sophia commentedI tested it, but now all newsletters are sent in English, even though some testers indicated other languages... guess it still is not flawless :)
Comment #7
sutharsan commentedYou need to create a new translation of the newsletter. Re-using the translation node of the previous patch will not work. Best way to test is to re-create the hole situation.
Comment #8
Sophia commentedYou are QUITE right, that did the trick, and I can confirm it all works great now :)
Comment #9
sutharsan commentedPatch committed to HEAD and 6.x-1.x-dev. Thanks for testing!