Problem/Motivation

A few APIs were deprecated in commerce:3.0.0 for removal in commerce:4.0.0.

Proposed resolution

Remove:

  • Drupal\commerce_payment\Form\PaymentAddForm
  • PaymentGatewayInterface::getJsLibrary(), replaced by getLibraries()
  • The js_library property of the CommercePaymentGateway annotation, replaced by libraries

Remaining tasks

  • Remove the deprecated code and any BC layer using it.

User interface changes

None.

API changes

The deprecated APIs listed above are removed.

Data model changes

None.

Issue fork commerce-3638819

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

Status: Active » Needs review

Pushed a first pass to the issue fork (branch 3638819-remove-code-deprecated) that removes:

  • PaymentGatewayInterface::getJsLibrary() and the js_library annotation/attribute property. libraries has existed since 3.0.0, so a gateway can switch once and support both 3.x and 4.x.
  • PaymentAddForm, along with the commerce_payment_use_legacy_add_payment_form setting and the route subscriber behind it. The route now points straight at OrderPaymentAddForm.

I'm not sure about the second part yet. The form was marked deprecated in 3.0.0, but the setting that keeps it was only added in 3.3.0, so sites were told fairly recently that they could keep the two-step form. The alternative is to keep it in 4.0 and change the deprecation to removal in 5.0.0.

Leaving this open for feedback, particularly from anyone still using the legacy form. Moving on to #3638818 in the meantime.