Problem/Motivation

The page title in default admin has less top margin than bottom and it almost touches the edge. Looks off.

Proposed resolution

Remaining tasks

N/A

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3637899

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pameeela created an issue. See original summary.

akshay kashyap’s picture

I tested the change locally and compared the result with the original screenshot. The page title now has better spacing at the top and looks more balanced.

Increasing the top margin to `var(--admin-space-m)` seems to work well. The existing bottom margin is unchanged, so the spacing below the title is maintained.

I didn't notice any layout issues during my testing, and the change looks good to me.

One small suggestion: the MR title mentions padding, but the actual change is to the margin. It would be good to update the title for clarity.

akshay kashyap’s picture

Status: Active » Needs review
akshay kashyap’s picture

StatusFileSize
new67.41 KB
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new1.01 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

pameeela’s picture

I didn’t commit the generated CSS so this needs to be fixed.

akshay kashyap’s picture

Thanks for the automated test report. I checked the failure and found that the compiled CSS was not in sync with the source CSS file.

I've rebuilt the CSS using `yarn run build:css` and pushed the updated changes to the issue fork.

The other checks, including CSpell, PHPStan and Stylelint, were already passing. I'll check the updated test results once the bot runs again.

akshay kashyap’s picture

Status: Needs work » Needs review