Noticed by accident, in dark mode the background in long text ckeditor based fields is white in dark mode on node edit forms for full and basic html text formats:
Turns out the problem was introduced with #3633459: Update CKEditor to 49.1.0. I went through the history looking for any issue related with ckeditor changes. the linked one was for updating ckeditor to version 49.1.0. I've discussed the problem with @kentr, and he was able to reproduce the issue after updating to the latest changes of main. the problem is not browser specific, is reproducible in safari and edge. he suggested to make sure it would be good to checkout specific commits:
git checkout -f acfffb4307a^ => the long text field is styled correctly
git checkout -f acfffb4307a => the long text field styling is broken in dark mode in default admin
Which is the proof that something broke with the update to 49.1.0
Create a content type with a long text field and create a node of that content type
Ensure that the background for long text fields is not white for any text format and it meets the style of dark mode every time and in consequence that all text within that long text field has a color contrast of at least 4.5:1
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 2026-11-12_12:40:28.png | 19.6 KB | salmonek |
| #9 | 2026-11-12_12:39:52.png | 21.84 KB | salmonek |
| #7 | 2026-11-10_12:45:00.png | 17.93 KB | salmonek |
| #7 | 2026-11-10_12:43:58.png | 22.9 KB | salmonek |
| plain.jpg | 22.7 KB | rkoller |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
rkollerComment #3
rkollerI would even consider it a priority of critical instead of major since node edit forms are one of the main top tasks users do.
Comment #4
rkollerUpdated the issue summary isolating the commit that introduced that problem thanks to @kentr
Comment #5
rkollerComment #6
rkollerComment #7
salmonek commentedThere is more than editing area background. I noticed also issues with fullscreen, toolbar button clicked bg and balloons bg.
This may be a good opportunity to update to new design tokens system introduced in 49.0.0:
https://ckeditor.com/docs/ckeditor5/latest/framework/deep-dive/ui/theme-...
https://ckeditor.com/docs/ckeditor5/latest/framework/deep-dive/ui/theme-...
Legacy variables are still present, however at some point they will be removed from CKEditor and migration will be mandatory (there is no specified deprecation date as for now).
I have prepared a patch that replaces old variables with new token system. I aimed to preserve the previous look and ensure that dark mode issues are fixed. I'll post MR shortly.
Comment #9
salmonek commentedAfter changes:
As for the tooltip issue: https://www.drupal.org/project/drupal/issues/3633459#comment-16826554
The
--ck-balloon-panel-background-colorvariable is not resolved now, so I hardcoded the previous resolve color:Comment #10
salmonek commentedPerformance tests are failing. The stylesheet bytes doesn't match assert values. I'd like to update them once we have agreement that updates are ok to be merged.
Rest of failed tests are some PHP 8.6 Unit tests - failing both before and after changes.