Problem/Motivation

As the title states.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork photoswipe-3635319

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil opened merge request !169

grevil’s picture

grevil commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work

Great work - sadly sanitization removes links and seems to turn texts into images so they are no more searchable in the source image.

I think we could make sanitation a separate option - and for the linked source image use the output from the svg_image_field module unchanged?

I mean without our module the output would be the same nevertheless? And it's up to svg_image_field to create the correct and safe output?
We should inherit its options then?

grevil’s picture

grevil commented

Yes great idea, this would completely change the behavior of the formatter, but iMO it is fine, we just added it recently and as it stands it simply doesn't fit as a proper svg_image_field extension.

grevil’s picture

grevil commented
Assigned: grevil » anybody
Status: Needs work » Needs review

Alright, all done! Please review!

grevil’s picture

grevil commented

Ok now really all done, also check out https://www.drupal.org/project/photoswipe/issues/3635489.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
Status: Needs review » Reviewed & tested by the community

Very helpful and nice improvements. Was worth it. I think it's fine to release it without a new major version. We could instead bump the minor version in the next release. svg support was added recently, should be fine.

  • grevil committed 4aed25f4 on 5.x 
    task: #3635319 Add option to render "svg_image_field" formatter svg as...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Regression: #3636721: Too few arguments to function Drupal\svg_image_field\Plugin\Field\FieldFormatter\SvgImageFieldFormatter::__construct(), 11 passed in /modules/contrib/photoswipe/modules/photoswipe_svg_image_field/src/Plugin/Fie