The DisabledDefaultTags test is failing:

Disabled Default Tags (Drupal\Tests\metatag\Functional\DisabledDefaultTags)
 ⚠ Frontpage
 ⚠ 404
 ⚠ 403
 ⚠ None
 ⚠ Entity type defaults
 ⚠ Entity bundle defaults
 ✘ Entity canonical and shortlink none
   ┐
   ┊ ---·Expected
   ┊ +++·Actual
   ┊ @@ @@
   ┊ -'http://localhost/web/node/1'
   ┊ +'https://test.canonical'
   │
   │ /builds/project/metatag/tests/src/Functional/DisabledDefaultTagsTest.php:385

Also this is failing:

    Core Tag Removal (Drupal\Tests\metatag_mobile\Functional\CoreTagRemovalTest)
     ✘ Removal core tag
       ┐
       ├ The link General was not found on the page.  
       ├ Failed asserting that an array has the key 0.
       │
       │ /builds/project/metatag/web/core/tests/Drupal/Tests/UiHelperTrait.php:462
       │ /builds/project/metatag/web/core/modules/field_ui/tests/src/Traits/FieldUiTestTrait.php:72
       │ /builds/project/metatag/metatag_mobile/tests/src/Functional/CoreTagRemovalTest.php:54

Issue fork metatag-3633335

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Resolve problem with DisabledDefaultTags test with 10.6 » Resolve problem with DisabledDefaultTagsTest with 10.6
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Resolve problem with DisabledDefaultTagsTest with 10.6 » Resolve problem with DisabledDefaultTagsTest
Assigned: Unassigned » damienmckenna
Issue summary: View changes

damienmckenna opened merge request !291

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Resolve problem with DisabledDefaultTagsTest » Resolve problem with tests in 2.2.x branch
Issue summary: View changes
Parent issue: » #3632962: Plan for Metatag 2.2.2
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned
Status: Active » Needs work

I fixed one test and now another one is failing that was working fine before.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented

Looks like the MetatagEntitiesTest error in the original MR pipeline run was a database server shutdown mid-run. It passed when I triggered another run of the pipelines on your MR.

I think the CoreTagRemovalTest failure may be due to the standard install profile no longer including the basic page content type as of 11.4 (see related core change record).

Perhaps that test could be updated to no longer use the standard profile and just include a step to create the content type?

$this->drupalCreateContentType(['type' => 'page', 'name' => 'Basic page']);
joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
Status: Needs work » Needs review

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

@joegraduate: Well spotted, thank you.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.