Problem/Motivation

Since 2.2.1, the descriptions under each meta tag field on the forms are gone.

#3398796: Add PHP attributes for all plugins changed the constructors in MetaNameBase and GroupBase to read the description from $configuration['description']. It's stored in $plugin_definition['description'], so it is always empty.

Steps to reproduce

Open the meta tag defaults form (/admin/config/search/metatag/global) and expand a group. The fields have no help text.

Proposed resolution

Read the description from $plugin_definition in both constructors, and fall back to '' like 2.2.0 did.

Remaining tasks

Create an MR.

#3632998: Version 2.2.1 breaks external_hreflang module

CommentFileSizeAuthor
#6 before.png59.96 KBf0ns
#6 after.png148.67 KBf0ns

Issue fork metatag-3633005

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

f0ns created an issue. See original summary.

f0ns opened merge request !281

f0ns’s picture

f0ns commented
Status: Active » Needs review
gillesbailleux’s picture

gillesbailleux
Primary language French
Location La Roche-en-Ardenne
commented

@f0ns: on two Drupal CMS instances using D11.4.11 and equipped with PHP 8.5.12, all the descriptions under each meta tag field remain visible (either on [site:base-url]/admin/config/search/metatag/global and nodes) after upgrading from v2.2.0 to v2.2.1

I did not update any non-Drupal CMS D11 instance, so I cannot reproduce the issue.

gillesbailleux’s picture

gillesbailleux
Primary language French
Location La Roche-en-Ardenne
commented

@f0ns: after upgrading a D11.4.11 instance equipped with PHP 8.3.36, all the descriptions under each meta tag field remain visible (either on [site:base-url]/admin/config/search/metatag/global and nodes) after upgrading from v2.2.0 to v2.2.1

f0ns’s picture

f0ns commented
StatusFileSize
new after.png148.67 KB
new before.png59.96 KB

That's weird.

I just did a test to be 100% sure and here is the result

Before

Before

After

After

gillesbailleux’s picture

gillesbailleux
Primary language French
Location La Roche-en-Ardenne
commented

@f0ns: my apologies as I have exactly the same situation you mention in the printescreen above.

The "Set to to disable inheritance of the parent value and prevent the output of this metatag entirely." description remains but the whole description has disappeared.

f0ns’s picture

f0ns commented

No problem!

After rereading my initial post the steps to reproduce perhaps were not clear enough.

Thanks for testing!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community
Parent issue: » #3632962: Plan for Metatag 2.2.2

Thank you for the bug report, I'm sorry another bug showed up. I opened #3633219: Add test coverage for plugin descriptions so that we can have test coverage for these descriptions to make sure they don't disappear again.

  • damienmckenna committed dc663605 on 2.2.x authored by f0ns 
    Issue #3633005 by f0ns, gillesbailleux, DamienMcKenna: Tag and group...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 2.2.x-dev » 2.2.1
Status: Reviewed & tested by the community » Fixed

Committed. Thanks again.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.