Problem/Motivation

Following #3397864: Add optional DDEV dev environment, the distributed packages contain files for a DDev environment, which are not required to use the software. The DDev environment contains several command files in bash.

We can use .gitattributes to export-ignore some files, reducing package size and surface area.

Steps to reproduce

wget https://ftp.drupal.org/files/projects/memcache-8.x-2.9.zip
unzip memcache-8.x-2.9.zip

Proposed resolution

Use .gitattributes to reduce the package surface area, excluding .ddev

Remaining tasks

Questions:

  1. Is it OK as is - was it intentional / desirable to include these? Not clear from #3397864: Add optional DDEV dev environment.
  2. Should other files also be excluded? Please add to MR if so :)
  3. Should .gitattributes be in .gitignore?

Tasks:

  1. MR changes to .gitattributes
  2. Verify if the packaging system does the expected thing.

User interface changes

API changes

Data model changes

Issue fork memcache-3632574

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

xurizaemon created an issue. See original summary.

xurizaemon’s picture

Issue summary: View changes
xurizaemon’s picture

Issue summary: View changes

japerry made their first commit to this issue’s fork.

japerry’s picture

Status: Active » Needs review

Great find! (I've applied this to my global module contrib maintainer template).

In short, yes we should be excluding it and composer does honor it. I've rebased it on the recent D12 compatibility patch, and added some more exports, as we don't need drupal ci or gitignore as part of composer packages either.

  • japerry committed 5a547a0c on 8.x-2.x
    Issue #3632574 by xurizaemon, japerry: Exclude development files from...

  • japerry committed bbeb5f1c on 8.x-2.x
    chore: #3632574 Keep ddev poser from overwriting .gitattributes and...

japerry’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.