Problem/Motivation
Drupal core 11.4.9 changed the ckeditor5 library version in core/core.libraries.yml from 47.6.3 to 47.6.3-drupal.1 (core #3625998).
SettingsConfigHandler::getDllVersion() maps only 47.6.3 to 47.7.4 and otherwise returns the core version as is. So the premium plugin scripts are requested from https://cdn.ckeditor.com/ckeditor5/47.6.3-drupal.1/dll/..., which returns 404, while the 47.7.4 files return 200.
Result: premium plugins fail to load with JavaScript errors in the editor, and the Layout Builder "Configure block" dialog can fail to open. Found in the Varbase Project 10.1.5 release pipeline: 8 of 15 functional suites failed on core 11.4.9 with 1.8.5, and core 11.4.8 worked.
Steps to reproduce
- Drupal core 11.4.9 with CKEditor 5 Premium Features 1.8.5, a premium plugin enabled on a text format.
- Open a content form that uses that format.
- The console shows 404s for
https://cdn.ckeditor.com/ckeditor5/47.6.3-drupal.1/dll/...and the premium plugins do not load.
Proposed resolution
In getDllVersion(), strip a trailing -drupal.N build suffix from the core version before the mapping lookup. 47.6.3-drupal.1 then resolves to 47.7.4, and later core rebuilds resolve to the published CDN version.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ✅ Reviewed by a human
- ✅ Code review by maintainers
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Premium plugins load again on Drupal core 11.4.9, whose CKEditor 5 version carries a
-drupal.1suffix.
Issue fork ckeditor5_premium_features-3629880
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahComment #5
salmonek commentedThanks,
Reviewed, tested with 47.6.2, 47.6.3 and 47.6.3-drupal.1 and it'll be released today to ensure compatibility with Drupal version that will be released later today.
Comment #6
salmonek commentedReleased in 1.8.6
Comment #8
neclimdul