Problem/Motivation

@Action annotations are deprecated; see change record "Plugin implementations should use PHP attributes instead of annotations".

Proposed resolution

Replace @Action annotations with PHP attributes.

Remaining tasks

Implement.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 Screenshot 2026-10-27 at 11.31.05 AM.png208.77 KBishfaqafridi85

Issue fork webform-3628840

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

avinash.jha made their first commit to this issue’s fork.

avinash.jha opened merge request !965

avinash.jha’s picture

avinash.jha commented

Replaced the @Action annotations with #[Action] PHP attributes in all 10 action plugins in src/Plugin/Action. Plugin IDs, labels, types and confirm_form_route_name values are unchanged, so existing action config is not affected. The attribute is available since Drupal 10.2, and the module already requires ^10.3. Ready for review.

avinash.jha’s picture

avinash.jha commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Needs work

Thanks for the patch. Tests are not passing.

ishfaqafridi85’s picture

ishfaqafridi85 commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot 2026-10-27 at 11.31.05 AM.png208.77 KB

I checked the failed pipeline. PHPUnit fails in WebformImageSelectElementTest::testImageSelect() at line 60 because the expected preview image is not found.

The same failure appears in the unchanged 6.3.x pipeline #1015824, so it appears unrelated to the annotation changes in MR !965.

Could we track the image-select test failure in a separate issue, if it is not already reported?

For reference screenshot attached