Problem/Motivation

In #3490391: Make listing revisions an option on the list usage page entity_usage added the ability to exclude past revisions from display on the usage tab. This is amazing but unfortunately breaks the extending controller in this module.

Update the controller to be compatible with the 5.0.1 version of entity_usage.

*NOTE* there appears to be a display issue with entity_usage when Claro is set as the admin theme: https://www.drupal.org/project/entity_usage/issues/3629517

Issue fork entity_usage_plus-3626824

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jastraat created an issue. See original summary.

jasongose made their first commit to this issue’s fork.

jasongose opened merge request !10

jasongose opened merge request !11

jasongose’s picture

jasongose commented

I have a partial solution (it meets my immediate needs, but I think there's some opportunity for improvement that could benefit others).

I ran in to some difficulty including the handy 'show usage in old revision' filter when your site is configured to use Claro as the admin theme that caused the dropdown button to not work quite right after toggling the filter; I opened an issue, but since we're talking about the Claro theme, it might just be out of scope for the 5.0.x entity_usage releases.

I think it would be nice to 2 additional options in entity_usage_plus:
- One to toggle the 'show usage in old revision' filter on the usage tab/page
- One to set the default value for the filter on the usage tab/page

jasongose changed the visibility of the branch 3626824-make-2.x-branch to hidden.

jasongose changed the visibility of the branch 3626824-make-2.x-branch to active.

jasongose’s picture

jasongose commented
Issue summary: View changes
jasongose’s picture

jasongose commented

Removed the list_old_revisions option and always show old revisions

jasongose’s picture

jasongose commented
Status: Active » Needs review
jastraat’s picture

jastraat commented

This allows entity_usage_plus to work with the 5.0.1 version of entity_usage. Would suggest updating the composer.json and info.yml to specify 5.0.1 since it wouldn't be compatible with earlier versions of 5.x

jastraat’s picture

jastraat commented
Status: Needs review » Reviewed & tested by the community

Looks great! Thanks Jason!

jastraat’s picture

jastraat commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • jastraat committed 570380df on 2.0.x authored by jasongose 
    task: #3626824 Update the controller to be compatible with entity_usage...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.