Problem/Motivation

Discovered while converting Unit and Kernel tests to use Default Admin. #3582093: Convert Unit and Kernel tests that use Claro to Admin

In default_admin.libraries.yml there is 

# Custom CSS

admin_custom_css:
  css:
    theme:
      public://admin-custom.css: { preprocess: false, minified: false, weight: 50 }

I don't think core should do this.

Steps to reproduce

Proposed resolution

Remove the feature

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3621981_updated_library_list_for_default_admin.patch512 byteshoxton

Issue fork drupal-3621981

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

hoxton’s picture

hoxton commented
StatusFileSize
new 3621981_updated_library_list_for_default_admin.patch512 bytes
hoxton’s picture

hoxton commented

It sounds right thing to do. The file does not even exists first place.

hoxton’s picture

hoxton commented
Status: Active » Needs review
daffie’s picture

daffie commented
Status: Needs review » Needs work

@hoxton: Could you create an issue fork with the changes. See: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

quietone’s picture

quietone commented

Yes, the file in question does not exist in core nor would core provide files in the public directory.

@hoxton, Drupal core no longer uses a patch workflow. I suggest you read the Contributor Guide. In particular, Create a merge request for an issue.

hoxton opened merge request !17058

hoxton’s picture

hoxton commented

thanks @daffie and @quietone for pointing out the patch file concern. I have raised a PR for same.

daffie’s picture

daffie commented
Status: Needs work » Reviewed & tested by the community

Looks good to me.

godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Needs work

Doing some archaelogy, this functionality was introduced to Gin in https://git.drupalcode.org/project/gin/-/work_items/3179676. A similar idea was proposed for Claro in #3169297: Provide an easy method for supplying a custom css file to Claro, but that's Closed (won't fix).

We also need to remove:

hoxton’s picture

hoxton commented

thanks @godotislate for pointing out the redundant use in default_admin's hook definitions.

Have updated the PR with requested changes.

hoxton’s picture

hoxton commented
Status: Needs work » Needs review
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

lgtm

  • mstrelan committed 3913d9cf on 11.x 
    task: #3621981 Remove admin-custom.css

By: quietone
By: hoxton
By:...

  • mstrelan committed 1ed8ef5d on main 
    task: #3621981 Remove admin-custom.css

By: quietone
By: hoxton
By:...
mstrelan’s picture

mstrelan commented
Version: main » 11.x-dev
Component: Claro theme » Admin theme
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1ed8ef5ddcd to main and 3913d9cfd2a to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented
Related issues: -#3582093: Convert Unit and Kernel tests that use Claro to Admin +#3576488: [meta] Admin theme: path to beta and stable

Correcting the related issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.