Summary

The message when Translation isn’t enabled for pages yet is really helpful, and provides a link to the settings, but the link doesn't work. Nothing happens when you click on it.

Steps to reproduce

Enable the module without translations enabled for pages
See the message and try to click the link, see nothing happens

Proposed resolution

CommentFileSizeAuthor
Screenshot 2026-09-09 at 1.41.57 pm.png67.3 KBpameeela

Issue fork canvas_translate-3621911

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pameeela created an issue. See original summary.

kieran.cott made their first commit to this issue’s fork.

kieran.cott opened merge request !10

kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented
Status: Active » Needs review

The Content language settings link was blocked because Canvas page-extension iframes cannot open new tabs. The link now navigates within the extension frame. I've also included an end-to-end regression test, updated the specification and rebuilt the frontend assets.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

I think we should add allow-popups to the iframe in Canvas because I don't think we should navigate within the extension frame. We could manage this temporarily by explaining how they can navigate there without providing a link.

pameeela opened merge request !11

pameeela’s picture

pameeela commented
Status: Needs work » Needs review

Makes sense, created a new MR that removes the link for now.

kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented

Sounds good, I'll close MR 10 in lieu of @pameeela's fix above.

We could manage this temporarily by explaining how they can navigate there without providing a link.

Looks like the message already does - I've checked out 3621911-remove-link locally and LGTM.

+1 RTBC

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Is the settings URL access checked anyway? I think if its not, then its also better this way that its not linked. Canvas itself does a half-done access check for the configure languages link as well as it keeps the separator in the dropdown even if the link is not there. See https://git.drupalcode.org/project/canvas/-/work_items/3591793

f0ns’s picture

f0ns commented

Reviewed MR !11. The source change looks right, two things I noticed:

  1. extension/dist/index.global.js wasn't rebuilt, so the shipped bundle still renders the old target="_blank" link. The build-assets CI job fails on this MR for the same reason (job). Needs npm run build in extension/ and the dist committed.
  2. The note under the steps still says "If the link above gives you 'Access denied', ask a site administrator to do this step." There's no link any more. Suggest: "Changing these settings needs administration permissions. If you don't have them, ask a site administrator."

Is there a Canvas issue for adding allow-popups to the page extension iframe? Would be good to link it here so the link can come back.

f0ns’s picture

f0ns commented
Status: Needs review » Needs work
f0ns’s picture

f0ns commented

Canvas issue for allow-popups (together with allow-forms): #3591911, MR !1714. Once that is in, the link can come back.

  • lauriii committed 9b37e5a8 on 1.0.x authored by pameeela 
    fix: #3621911 Link to Content language settings doesn't work

By:...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Fixed

Thank you for the MR! I changed from displaying the page label to displaying the URL path which makes is a bit easier if you don't know what you're looking for. Ideally we can fix the upstream issue which will allow us to make the experience here better.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.