Problem/Motivation
Updating to @vardot/varbase-e2e 2.0.4 breaks this test suite: 2 of the 6 scenarios stop with Multiple step definitions match. The library now ships the same step this module defines locally, so Cucumber sees two definitions for one sentence and will not guess:
Both are the permission-matrix scenarios this step exists for.
Then the page should be access restricted- Ours:
tests/step-definitions/varbase_layout_builder.steps.js:97 - The library's:
navigation.steps.js:310
Keep the library one. It accepts an access-denied page, a log-in form or a redirect to one, it navigates nowhere (so a refusal after a click is asserted where it happened), and it answers to both phrasings — which is why a local copy of either collides. Documented in docs/steps/navigation.md.
Steps to reproduce
- On
10.2.x, runnpm installso@vardot/varbase-e2eresolves 2.0.4. Add--legacy-peer-deps: pre-existing and unrelated,stylelint-config-prettier@9wantsstylelint < 15and the project is on 16. - Run
npx cucumber-js --dry-run. No site, no browser: the run stops before that.
6 scenarios (2 ambiguous, 4 skipped) 38 steps (2 ambiguous, 36 skipped)
Proposed resolution
- Delete the local step (and its doc block) from
tests/step-definitions/varbase_layout_builder.steps.js, plus theThenimport it was the only user of, and refresh the@filenote. Nothing else in that file changes. - Require
@vardot/varbase-e2e^2.0.4. - No feature file changes: the sentence is identical.
Dry-run after the change: 6 scenarios, 38 steps, nothing ambiguous, nothing undefined. The browser suite needs a live site, so CI is what confirms the scenarios still pass.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support
- ➖ User Guide Documentation support
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ❌ Reviewed by a human
- ❌ Code review by maintainers
- ❌ Full testing and approval
- ❌ Credit contributors
- ❌ Review with the product owner
- ✅ Update Release Notes
- ✅ Release
User interface changes
- None. This is the test suite only.
API changes
- None.
Data model changes
- None.
Release notes snippet
- Test suite: the access-restricted step now comes from @vardot/varbase-e2e 2.0.4 instead of a local copy.
Issue fork varbase_layout_builder-3621384
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahComment #5
rajab natshah