Problem/Motivation

Search is being moved to contrib but the Umami theme still has references, we should remove it from there - only needs to happen in main.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3620804

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch opened merge request !16988

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review

gábor hojtsy made their first commit to this issue’s fork.

godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Needs work

Umami performance tests need updates for stylesheet byte ranges.

quietone’s picture

quietone commented
Parent issue: #3565781: Deprecate the Search module » #3565780: [meta] Tasks to deprecate the Search module
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

updated performance tests.

quietone’s picture

quietone commented

On main I get the following

$ git grep -i search | grep -v array_search | grep -i umami | wc -l
103

I applied the diff and get the following

$ git grep -i search | grep -v array_search | grep -i umami | wc -l
0

So that is looking good.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +11.5.0 release priority

Looks good to me now, thanks for all the fixes. :)

  • amateescu committed dde124da on main 
    task: #3620804 Remove search references from Umami theme

By: catch
By:...
amateescu’s picture

amateescu commented
Version: main » 11.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed and pushed dde124da00f to main. Thanks!

Needs a 11.x backport MR.

quietone opened merge request !16993

quietone’s picture

quietone commented

I created an MR for 11.x. I had to make changes for the performance test.

catch’s picture

catch
he/him
Primary language English
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Looks good.

nicxvan’s picture

nicxvan commented

Looks good to me!

I reviewed the commit in 10 with the MR.

I did not compare the perf tests since they are now programmatically generated.

All other deletions and updates are consistent.

  • amateescu committed e943d853 on 11.x 
    task: #3620804 Remove search references from Umami theme

By: catch
By:...
amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Fixed

Committed e943d85 and pushed to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.